Re: [PATCH bpf-next v5 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-14 Thread Song Liu
> On Mar 14, 2018, at 9:07 AM, Daniel Borkmann wrote: > > Just a minor question below, the rest seems fine to me as far as I > can tell. > > On 03/13/2018 10:47 PM, Song Liu wrote: > [...] >> +enum bpf_stack_build_id_status { >> +/* user space need an empty entry to

Re: [PATCH bpf-next v5 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-14 Thread Daniel Borkmann
Just a minor question below, the rest seems fine to me as far as I can tell. On 03/13/2018 10:47 PM, Song Liu wrote: [...] > +enum bpf_stack_build_id_status { > + /* user space need an empty entry to identify end of a trace */ > + BPF_STACK_BUILD_ID_EMPTY = 0, > + /* with valid

[PATCH bpf-next v5 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-13 Thread Song Liu
Currently, bpf stackmap store address for each entry in the call trace. To map these addresses to user space files, it is necessary to maintain the mapping from these virtual address to symbols in the binary. Usually, the user space profiler (such as perf) has to scan /proc/pid/maps at the