Re: [PATCH ethtool] ethtool: Fix uninitialized variable use at qsfp dump

2018-10-02 Thread Eran Ben Elisha
On 9/27/2018 7:08 PM, Andrew Lunn wrote: > On Thu, Sep 27, 2018 at 04:48:35PM +0300, Eran Ben Elisha wrote: >> Struct sff_diags can be used uninitialized at sff8636_show_dom, this >> caused the tool to show unreported fields (supports_alarms) by the lower >> level driver. >> >> Fixes:

Re: [PATCH ethtool] ethtool: Fix uninitialized variable use at qsfp dump

2018-09-27 Thread Andrew Lunn
On Thu, Sep 27, 2018 at 04:48:35PM +0300, Eran Ben Elisha wrote: > Struct sff_diags can be used uninitialized at sff8636_show_dom, this > caused the tool to show unreported fields (supports_alarms) by the lower > level driver. > > Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics

[PATCH ethtool] ethtool: Fix uninitialized variable use at qsfp dump

2018-09-27 Thread Eran Ben Elisha
Struct sff_diags can be used uninitialized at sff8636_show_dom, this caused the tool to show unreported fields (supports_alarms) by the lower level driver. Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support") Signed-off-by: Eran Ben Elisha --- qsfp.c | 2 +- 1 file