Re: [PATCH iproute2] ip: mroute: Add table output to show command

2017-06-14 Thread Stephen Hemminger
On Wed, 14 Jun 2017 08:08:12 -0400 Donald Sharp wrote: > When the user specifies `table all` or `table 0` to > the `ip mroute show` command we dump the entirety of > the known mroute tables. Without some sort of > divisor to tell us what table we are looking at > the

Re: [PATCH iproute2] ip: mroute: Add table output to show command

2017-06-14 Thread David Ahern
On 6/14/17 9:44 AM, Nikolay Aleksandrov wrote: > On 14/06/17 18:42, David Ahern wrote: >> On 6/14/17 6:08 AM, Donald Sharp wrote: >>> diff --git a/ip/ipmroute.c b/ip/ipmroute.c >>> index 4d2d758..70f4c4f 100644 >>> --- a/ip/ipmroute.c >>> +++ b/ip/ipmroute.c >>> @@ -189,6 +189,11 @@ int

Re: [PATCH iproute2] ip: mroute: Add table output to show command

2017-06-14 Thread Nikolay Aleksandrov
On 14/06/17 18:42, David Ahern wrote: > On 6/14/17 6:08 AM, Donald Sharp wrote: >> diff --git a/ip/ipmroute.c b/ip/ipmroute.c >> index 4d2d758..70f4c4f 100644 >> --- a/ip/ipmroute.c >> +++ b/ip/ipmroute.c >> @@ -189,6 +189,11 @@ int print_mroute(const struct sockaddr_nl *who, struct >> nlmsghdr

Re: [PATCH iproute2] ip: mroute: Add table output to show command

2017-06-14 Thread David Ahern
On 6/14/17 6:08 AM, Donald Sharp wrote: > diff --git a/ip/ipmroute.c b/ip/ipmroute.c > index 4d2d758..70f4c4f 100644 > --- a/ip/ipmroute.c > +++ b/ip/ipmroute.c > @@ -189,6 +189,11 @@ int print_mroute(const struct sockaddr_nl *who, struct > nlmsghdr *n, void *arg) > fprintf(fp, ",

Re: [PATCH iproute2] ip: mroute: Add table output to show command

2017-06-14 Thread Nikolay Aleksandrov
On 14/06/17 15:08, Donald Sharp wrote: > When the user specifies `table all` or `table 0` to > the `ip mroute show` command we dump the entirety of > the known mroute tables. Without some sort of > divisor to tell us what table we are looking at > the command is useless. > > Add `Table: ` to the

[PATCH iproute2] ip: mroute: Add table output to show command

2017-06-14 Thread Donald Sharp
When the user specifies `table all` or `table 0` to the `ip mroute show` command we dump the entirety of the known mroute tables. Without some sort of divisor to tell us what table we are looking at the command is useless. Add `Table: ` to the output of 'ip mroute show table 0' Follow the