Re: [PATCH iproute2] iproute: make clang happy

2018-08-21 Thread महेश बंडेवार
On Mon, Aug 20, 2018 at 5:52 PM, Stephen Hemminger wrote: > On Mon, 20 Aug 2018 16:44:28 -0700 > Mahesh Bandewar (महेश बंडेवार) wrote: > >> On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार) >> wrote: >> > On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger >> > wrote: >> >> On

Re: [PATCH iproute2] iproute: make clang happy

2018-08-20 Thread Stephen Hemminger
On Mon, 20 Aug 2018 16:44:28 -0700 Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार) > wrote: > > On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger > > wrote: > >> On Mon, 20 Aug 2018 14:42:15 -0700 > >> Mahesh Bandewar wrote: > >> >

Re: [PATCH iproute2] iproute: make clang happy

2018-08-20 Thread महेश बंडेवार
On Mon, Aug 20, 2018 at 4:44 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार) > wrote: >> On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger >> wrote: >>> On Mon, 20 Aug 2018 14:42:15 -0700 >>> Mahesh Bandewar wrote: >>> diff

Re: [PATCH iproute2] iproute: make clang happy

2018-08-20 Thread महेश बंडेवार
On Mon, Aug 20, 2018 at 3:50 PM, Stephen Hemminger wrote: > On Mon, 20 Aug 2018 14:42:15 -0700 > Mahesh Bandewar wrote: > >> >> if (is_json_context()) { >> + json_writer_t *jw; >> + >> open_json_object("bittiming"); >>

Re: [PATCH iproute2] iproute: make clang happy

2018-08-20 Thread महेश बंडेवार
On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger > wrote: >> On Mon, 20 Aug 2018 14:42:15 -0700 >> Mahesh Bandewar wrote: >> >>> diff --git a/tc/m_ematch.c b/tc/m_ematch.c >>> index ace4b3dd738b..a524b520b276 100644 >>>

Re: [PATCH iproute2] iproute: make clang happy

2018-08-20 Thread महेश बंडेवार
On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger wrote: > On Mon, 20 Aug 2018 14:42:15 -0700 > Mahesh Bandewar wrote: > >> diff --git a/tc/m_ematch.c b/tc/m_ematch.c >> index ace4b3dd738b..a524b520b276 100644 >> --- a/tc/m_ematch.c >> +++ b/tc/m_ematch.c >> @@ -277,6 +277,7 @@ static int

Re: [PATCH iproute2] iproute: make clang happy

2018-08-20 Thread Stephen Hemminger
On Mon, 20 Aug 2018 14:42:15 -0700 Mahesh Bandewar wrote: > diff --git a/tc/m_ematch.c b/tc/m_ematch.c > index ace4b3dd738b..a524b520b276 100644 > --- a/tc/m_ematch.c > +++ b/tc/m_ematch.c > @@ -277,6 +277,7 @@ static int flatten_tree(struct ematch *head, struct > ematch *tree) > return

Re: [PATCH iproute2] iproute: make clang happy

2018-08-20 Thread Stephen Hemminger
On Mon, 20 Aug 2018 14:42:15 -0700 Mahesh Bandewar wrote: > > if (is_json_context()) { > + json_writer_t *jw; > + > open_json_object("bittiming"); > print_int(PRINT_ANY, "bitrate", NULL, bt->bitrate); > -

[PATCH iproute2] iproute: make clang happy

2018-08-20 Thread Mahesh Bandewar
From: Mahesh Bandewar These are primarily fixes for "string is not string literal" warnings / errors (with -Werror -Wformat-nonliteral). This should be a no-op change. I had to replace couple of print helper functions with the code they call as it was becoming harder to eliminate these warnings,