Re: [PATCH iproute2 -next] ingress, clsact: don't add TCA_OPTIONS to nl msg

2016-05-17 Thread Daniel Borkmann
On 05/17/2016 01:54 PM, Jamal Hadi Salim wrote: On 16-05-15 12:36 PM, Daniel Borkmann wrote: In ingress and clsact qdisc TCA_OPTIONS are ignored, since it's parameterless. In tc, we add an empty addattr_l(... TCA_OPTIONS, NULL, 0) to the netlink message nevertheless. This has the side effect

Re: [PATCH iproute2 -next] ingress, clsact: don't add TCA_OPTIONS to nl msg

2016-05-17 Thread Jamal Hadi Salim
On 16-05-15 12:36 PM, Daniel Borkmann wrote: In ingress and clsact qdisc TCA_OPTIONS are ignored, since it's parameterless. In tc, we add an empty addattr_l(... TCA_OPTIONS, NULL, 0) to the netlink message nevertheless. This has the side effect that when someone tries a 'tc qdisc replace' and

Re: [PATCH iproute2 -next] ingress, clsact: don't add TCA_OPTIONS to nl msg

2016-05-16 Thread Stephen Hemminger
On Sun, 15 May 2016 18:36:03 +0200 Daniel Borkmann wrote: > In ingress and clsact qdisc TCA_OPTIONS are ignored, since it's > parameterless. In tc, we add an empty addattr_l(... TCA_OPTIONS, > NULL, 0) to the netlink message nevertheless. This has the > side effect that

[PATCH iproute2 -next] ingress, clsact: don't add TCA_OPTIONS to nl msg

2016-05-15 Thread Daniel Borkmann
In ingress and clsact qdisc TCA_OPTIONS are ignored, since it's parameterless. In tc, we add an empty addattr_l(... TCA_OPTIONS, NULL, 0) to the netlink message nevertheless. This has the side effect that when someone tries a 'tc qdisc replace' and already an existing such qdisc is present, tc