Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-10 Thread Nikolay Aleksandrov
On 10/09/17 21:18, Roman Mashak wrote: > Nikolay Aleksandrov writes: > >> On 10/09/17 16:38, Roman Mashak wrote: > > [...] > >>> Since VLAN info is already in link messages, there is no other option but >>> dump it in monitor or "bridge link show". Yes, the output

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-10 Thread Roman Mashak
Nikolay Aleksandrov writes: > On 10/09/17 16:38, Roman Mashak wrote: [...] >> Since VLAN info is already in link messages, there is no other option but >> dump it in monitor or "bridge link show". Yes, the output may be lengthy > > To make sure there's no

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-10 Thread Nikolay Aleksandrov
On 10/09/17 16:38, Roman Mashak wrote: > Roopa Prabhu writes: > >> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: >>> Signed-off-by: Roman Mashak >>> --- >>> bridge/link.c | 16 +--- >>> 1 file changed, 13

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-10 Thread Roman Mashak
Roopa Prabhu writes: > On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: >> Signed-off-by: Roman Mashak >> --- >> bridge/link.c | 16 +--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-10 Thread Nikolay Aleksandrov
On 09/09/17 20:23, Jamal Hadi Salim wrote: > On 17-09-09 12:24 PM, Roopa Prabhu wrote: >> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: [snip] > > Agree we should be turning on this stuff by default. i.e default stays > compressed; otherwise it a huge dump. > > Having

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Roopa Prabhu
On Sat, Sep 9, 2017 at 11:15 AM, Nikolay Aleksandrov wrote: > On 09/09/17 20:23, Jamal Hadi Salim wrote: >> On 17-09-09 12:24 PM, Roopa Prabhu wrote: >>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: Signed-off-by: Roman Mashak

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Roopa Prabhu
On Sat, Sep 9, 2017 at 10:23 AM, Jamal Hadi Salim wrote: > On 17-09-09 12:24 PM, Roopa Prabhu wrote: >> >> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: >>> >>> Signed-off-by: Roman Mashak >>> --- >>> bridge/link.c | 16

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Nikolay Aleksandrov
On 09/09/17 20:23, Jamal Hadi Salim wrote: > On 17-09-09 12:24 PM, Roopa Prabhu wrote: >> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: >>> Signed-off-by: Roman Mashak >>> --- >>> bridge/link.c | 16 +--- >>> 1 file changed, 13

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Jamal Hadi Salim
On 17-09-09 12:24 PM, Roopa Prabhu wrote: On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: Signed-off-by: Roman Mashak --- bridge/link.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/bridge/link.c

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Roopa Prabhu
On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > bridge/link.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/bridge/link.c b/bridge/link.c > index 60200f1..9e4206f 100644

[PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-08 Thread Roman Mashak
Signed-off-by: Roman Mashak --- bridge/link.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/bridge/link.c b/bridge/link.c index 60200f1..9e4206f 100644 --- a/bridge/link.c +++ b/bridge/link.c @@ -461,9 +461,19 @@ static int