Re: [PATCH linux-firmware] linux-firmware: liquidio: fix GPL compliance issue
On Wed, Oct 17, 2018 at 5:09 PM John W. Linville wrote: > > On Wed, Oct 17, 2018 at 07:34:42PM +, Manlunas, Felix wrote: > > On Fri, Sep 28, 2018 at 04:50:51PM -0700, Felix Manlunas wrote: > > > Part of the code inside the lio_vsw_23xx.bin firmware image is under GPL, > > > but the LICENCE.cavium file neglects to indicate that. However, > > > LICENCE.cavium does correctly specify the license that covers the other > > > Cavium firmware images that do not contain any GPL code. > > > > > > Fix the GPL compliance issue by adding a new file, > > > LICENCE.cavium_liquidio, > > > which correctly shows the GPL boilerplate. This new file specifies the > > > licenses for all liquidio firmware, including the ones that do not have > > > GPL code. > > > > > > Change the liquidio section of WHENCE to point to LICENCE.cavium_liquidio. > > > > > > Reported-by: Florian Weimer > > > Signed-off-by: Manish Awasthi > > > Signed-off-by: Manoj Panicker > > > Signed-off-by: Faisal Masood > > > Signed-off-by: Felix Manlunas > > > --- > > > LICENCE.cavium_liquidio | 429 > > > > > > WHENCE | 2 +- > > > 2 files changed, 430 insertions(+), 1 deletion(-) > > > create mode 100644 LICENCE.cavium_liquidio > > > > Hello Maintainers of linux-firmware.git, > > > > Any feedback about this patch? > > I would prefer to see an offer that included a defined URL for anyone > to download the source for the kernel in question without having to > announce themselves. The "send an email to i...@cavium.com" offer may > (or may not) be sufficient for the letter of the law. But it seems > both fragile and prone to subjective frustrations and delays for > users to obtain the sources at some future date. I agree with John here, but I also believe the patch is better than the current text in the upstream repo. I've committed it and pushed it out. If there are improvements to be made on source availability, we can take those in a different patch. Thank you for taking this seriously and responding quickly. josh
Re: [PATCH linux-firmware] linux-firmware: liquidio: fix GPL compliance issue
On Wed, Oct 17, 2018 at 07:34:42PM +, Manlunas, Felix wrote: > On Fri, Sep 28, 2018 at 04:50:51PM -0700, Felix Manlunas wrote: > > Part of the code inside the lio_vsw_23xx.bin firmware image is under GPL, > > but the LICENCE.cavium file neglects to indicate that. However, > > LICENCE.cavium does correctly specify the license that covers the other > > Cavium firmware images that do not contain any GPL code. > > > > Fix the GPL compliance issue by adding a new file, LICENCE.cavium_liquidio, > > which correctly shows the GPL boilerplate. This new file specifies the > > licenses for all liquidio firmware, including the ones that do not have > > GPL code. > > > > Change the liquidio section of WHENCE to point to LICENCE.cavium_liquidio. > > > > Reported-by: Florian Weimer > > Signed-off-by: Manish Awasthi > > Signed-off-by: Manoj Panicker > > Signed-off-by: Faisal Masood > > Signed-off-by: Felix Manlunas > > --- > > LICENCE.cavium_liquidio | 429 > > > > WHENCE | 2 +- > > 2 files changed, 430 insertions(+), 1 deletion(-) > > create mode 100644 LICENCE.cavium_liquidio > > Hello Maintainers of linux-firmware.git, > > Any feedback about this patch? I would prefer to see an offer that included a defined URL for anyone to download the source for the kernel in question without having to announce themselves. The "send an email to i...@cavium.com" offer may (or may not) be sufficient for the letter of the law. But it seems both fragile and prone to subjective frustrations and delays for users to obtain the sources at some future date. Respectfully, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready.
Re: [PATCH linux-firmware] linux-firmware: liquidio: fix GPL compliance issue
On Fri, Sep 28, 2018 at 04:50:51PM -0700, Felix Manlunas wrote: > Part of the code inside the lio_vsw_23xx.bin firmware image is under GPL, > but the LICENCE.cavium file neglects to indicate that. However, > LICENCE.cavium does correctly specify the license that covers the other > Cavium firmware images that do not contain any GPL code. > > Fix the GPL compliance issue by adding a new file, LICENCE.cavium_liquidio, > which correctly shows the GPL boilerplate. This new file specifies the > licenses for all liquidio firmware, including the ones that do not have > GPL code. > > Change the liquidio section of WHENCE to point to LICENCE.cavium_liquidio. > > Reported-by: Florian Weimer > Signed-off-by: Manish Awasthi > Signed-off-by: Manoj Panicker > Signed-off-by: Faisal Masood > Signed-off-by: Felix Manlunas > --- > LICENCE.cavium_liquidio | 429 > > WHENCE | 2 +- > 2 files changed, 430 insertions(+), 1 deletion(-) > create mode 100644 LICENCE.cavium_liquidio Hello Maintainers of linux-firmware.git, Any feedback about this patch? Thanks, Felix
[PATCH linux-firmware] linux-firmware: liquidio: fix GPL compliance issue
Part of the code inside the lio_vsw_23xx.bin firmware image is under GPL,
but the LICENCE.cavium file neglects to indicate that. However,
LICENCE.cavium does correctly specify the license that covers the other
Cavium firmware images that do not contain any GPL code.
Fix the GPL compliance issue by adding a new file, LICENCE.cavium_liquidio,
which correctly shows the GPL boilerplate. This new file specifies the
licenses for all liquidio firmware, including the ones that do not have
GPL code.
Change the liquidio section of WHENCE to point to LICENCE.cavium_liquidio.
Reported-by: Florian Weimer
Signed-off-by: Manish Awasthi
Signed-off-by: Manoj Panicker
Signed-off-by: Faisal Masood
Signed-off-by: Felix Manlunas
---
LICENCE.cavium_liquidio | 429
WHENCE | 2 +-
2 files changed, 430 insertions(+), 1 deletion(-)
create mode 100644 LICENCE.cavium_liquidio
diff --git a/LICENCE.cavium_liquidio b/LICENCE.cavium_liquidio
new file mode 100644
index 000..72e6ae7
--- /dev/null
+++ b/LICENCE.cavium_liquidio
@@ -0,0 +1,429 @@
+This file contains licences pertaining to the following firmwares for
+LiquidIO (c) adapters
+
+1. lio_nic_23xx.bin, lio_210nv_nic.bin, lio_410nv_nic.bin
+2. lio_vsw_23xx.bin
+
+###
+
+1. lio_nic_23xx.bin, lio_210nv_nic.bin, lio_410nv_nic.bin
+
+Copyright (c) 2018, Cavium, Inc. All rights reserved.
+
+Software License Agreement
+
+ANY USE, REPRODUCTION, OR DISTRIBUTION OF THE ACCOMPANYING BINARY SOFTWARE
+CONSTITUTES LICENSEEE'S ACCEPTANCE OF THE TERMS AND CONDITIONS OF THIS
AGREEMENT.
+
+Licensed Software. Subject to the terms and conditions of this Agreement,
+Cavium, Inc. ("Cavium") grants to Licensee a worldwide, non-exclusive, and
+royalty-free license to use, reproduce, and distribute the binary software in
+its complete and unmodified form as provided by Cavium.
+
+Restrictions. Licensee must reproduce the Cavium copyright notice above with
+each binary software copy. Licensee must not reverse engineer, decompile,
+disassemble or modify in any way the binary software. Licensee must not use
+the binary software in violation of any applicable law or regulation. This
+Agreement shall automatically terminate upon Licensee's breach of any term or
+condition of this Agreement in which case, Licensee shall destroy all copies of
+the binary software.
+
+Warranty Disclaimer. THE LICENSED SOFTWARE IS OFFERED "AS IS," AND CAVIUM
+GRANTS AND LICENSEE RECEIVES NO WARRANTIES OF ANY KIND, WHETHER EXPRESS,
+IMPLIED, STATUTORY, OR BY COURSE OF COMMUNICATION OR DEALING WITH LICENSEE, OR
+OTHERWISE. CAVIUM AND ITS LICENSORS SPECIFICALLY DISCLAIM ANY IMPLIED
+WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, TITLE, OR
+NONINFRINGEMENT OF THIRD PARTY RIGHTS, CONCERNING THE LICENSED SOFTWARE,
+DERIVATIVE WORKS, OR ANY DOCUMENTATION PROVIDED WITH THE FOREGOING. WITHOUT
+LIMITING THE GENERALITY OF THE FOREGOING, CAVIUM DOES NOT WARRANT THAT THE
+LICENSED SOFTWARE IS ERROR-FREE OR WILL OPERATE WITHOUT INTERRUPTION, AND
+CAVIUM GRANTS NO WARRANTY REGARDING ITS USE OR THE RESULTS THEREFROM, INCLUDING
+ITS CORRECTNESS, ACCURACY, OR RELIABILITY.
+
+Limitation of Liability. IN NO EVENT WILL LICENSEE, CAVIUM, OR ANY OF CAVIUM'S
+LICENSORS HAVE ANY LIABILITY HEREUNDER FOR ANY INDIRECT, SPECIAL, OR
+CONSEQUENTIAL DAMAGES, HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
+FOR BREACH OF CONTRACT, TORT (INCLUDING NEGLIGENCE), OR OTHERWISE, ARISING OUT
+OF THIS AGREEMENT, INCLUDING DAMAGES FOR LOSS OF PROFITS, OR THE COST OF
+PROCUREMENT OF SUBSTITUTE GOODS, EVEN IF SUCH PARTY HAS BEEN ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGES.
+
+Export and Import Laws. Licensee acknowledges and agrees that the Licensed
+Software (including technical data and related technology) may be controlled by
+the export control laws, rules, regulations, restrictions and national security
+controls of the United States and other applicable foreign agencies (the
+"Export Controls"), and agrees not export or re-export, or allow the export or
+re-export of export-controlled the Licensed Software (including technical data
+and related technology) or any copy, portion or direct product of the foregoing
+in violation of the Export Controls. Licensee hereby represents that
+(i) Licensee is not an entity or person to whom provision of the Licensed
+Software (including technical data and related technology) is restricted or
+prohibited by the Export Controls; and (ii) Licensee will not export, re-export
+or otherwise transfer the export-controlled Licensed Software (including
+technical data and related technology) in violation of U.S. sanction programs
+or export control regulations to (a) any country, or national or resident of
+any country, subject to a United States trade embargo, (b) any person or entity
+to whom shipment is restricted or prohibited by the Export Controls,
