RE: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-23 Thread Yotam Gigi
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Friday, September 23, 2016 2:06 PM >To: Yotam Gigi <yot...@mellanox.com> >Cc: j...@mojatatu.com; netdev@vger.kernel.org >Subject: Re: [PATCH net] act_ife: Add support for machines with har

Re: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-23 Thread David Miller
From: Yotam Gigi Date: Wed, 21 Sep 2016 15:54:13 +0300 > Without that fix, the following could occur: ... I don't think what you are doing in mlxsw is valid. You can't set hard_header_len arbitrarily, it's the MAC length. If you need to prepend special headers or

RE: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-22 Thread Yotam Gigi
>-Original Message- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Friday, September 23, 2016 1:40 AM >To: Yotam Gigi <yot...@mellanox.com>; da...@davemloft.net; >netdev@vger.kernel.org; Roman Mashak <m...@mojatatu.com> >Subject: Re: [PATCH net] act

Re: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-22 Thread Jamal Hadi Salim
On 16-09-21 08:54 AM, Yotam Gigi wrote: Without that fix, the following could occur: - On encode ingress, the total amount of skb_pushes (in lines 751 and 753) was more than specified in cow. - On machines with hard_header_len > mac_len, the packet format was not Just curious: What

[PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

2016-09-21 Thread Yotam Gigi
Without that fix, the following could occur: - On encode ingress, the total amount of skb_pushes (in lines 751 and 753) was more than specified in cow. - On machines with hard_header_len > mac_len, the packet format was not according to the ife specifications, as the place reserved at the