Re: [PATCH net] amd-xgbe: Fix race between access of desc and desc index

2015-11-01 Thread David Miller
From: Tom Lendacky Date: Wed, 28 Oct 2015 08:48:36 -0500 > On 10/27/2015 09:50 PM, David Miller wrote: >> From: Tom Lendacky >> Date: Mon, 26 Oct 2015 17:13:54 -0500 >> >>> During Tx cleanup it's still possible for the descriptor data to be >>>

Re: [PATCH net] amd-xgbe: Fix race between access of desc and desc index

2015-10-28 Thread Tom Lendacky
On 10/27/2015 09:50 PM, David Miller wrote: From: Tom Lendacky Date: Mon, 26 Oct 2015 17:13:54 -0500 During Tx cleanup it's still possible for the descriptor data to be read ahead of the descriptor index. A memory barrier is required between the read of the descriptor

Re: [PATCH net] amd-xgbe: Fix race between access of desc and desc index

2015-10-27 Thread David Miller
From: Tom Lendacky Date: Mon, 26 Oct 2015 17:13:54 -0500 > During Tx cleanup it's still possible for the descriptor data to be > read ahead of the descriptor index. A memory barrier is required between > the read of the descriptor index and the start of the Tx cleanup

[PATCH net] amd-xgbe: Fix race between access of desc and desc index

2015-10-26 Thread Tom Lendacky
During Tx cleanup it's still possible for the descriptor data to be read ahead of the descriptor index. A memory barrier is required between the read of the descriptor index and the start of the Tx cleanup loop. This allows a change to a lighter-weight barrier in the Tx transmit routine just