Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Yuchung Cheng
On Tue, Jan 23, 2018 at 3:30 PM, Lawrence Brakmo wrote: > > > > On 1/23/18, 3:26 PM, "Alexei Starovoitov" > wrote: > > On Tue, Jan 23, 2018 at 08:19:54PM +, Lawrence Brakmo wrote: > > On 1/23/18, 11:50 AM, "Eric Dumazet" wrote: > > > > On Tue, 2018-01-23 at 14:39 -0500,

Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Lawrence Brakmo
On 1/23/18, 3:26 PM, "Alexei Starovoitov" wrote: On Tue, Jan 23, 2018 at 08:19:54PM +, Lawrence Brakmo wrote: > On 1/23/18, 11:50 AM, "Eric Dumazet" wrote: > > On Tue, 2018-01-23 at 14:39 -0500, Neal Cardwell wrote: > > On Tue, Jan 23, 2018 at 2:20 PM, Lawrence

Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Alexei Starovoitov
On Tue, Jan 23, 2018 at 08:19:54PM +, Lawrence Brakmo wrote: > On 1/23/18, 11:50 AM, "Eric Dumazet" wrote: > > On Tue, 2018-01-23 at 14:39 -0500, Neal Cardwell wrote: > > On Tue, Jan 23, 2018 at 2:20 PM, Lawrence Brakmo wrote: > > > On 1/23/18, 9:30 AM, "Yuchung Cheng" wrote: >

Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Yuchung Cheng
On Tue, Jan 23, 2018 at 12:19 PM, Lawrence Brakmo wrote: > > On 1/23/18, 11:50 AM, "Eric Dumazet" wrote: > > On Tue, 2018-01-23 at 14:39 -0500, Neal Cardwell wrote: > > On Tue, Jan 23, 2018 at 2:20 PM, Lawrence Brakmo wrote: > > > On 1/23/18, 9:30 AM, "Yuchung Cheng" wrote: > >

Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Lawrence Brakmo
On 1/23/18, 11:50 AM, "Eric Dumazet" wrote: On Tue, 2018-01-23 at 14:39 -0500, Neal Cardwell wrote: > On Tue, Jan 23, 2018 at 2:20 PM, Lawrence Brakmo wrote: > > On 1/23/18, 9:30 AM, "Yuchung Cheng" wrote: > > > > The original patch that changes TCP's congestion control

Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Eric Dumazet
On Tue, 2018-01-23 at 14:39 -0500, Neal Cardwell wrote: > On Tue, Jan 23, 2018 at 2:20 PM, Lawrence Brakmo wrote: > > On 1/23/18, 9:30 AM, "Yuchung Cheng" wrote: > > > > The original patch that changes TCP's congestion control via eBPF only > > re-initializes the new congestion control,

Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Neal Cardwell
On Tue, Jan 23, 2018 at 2:20 PM, Lawrence Brakmo wrote: > On 1/23/18, 9:30 AM, "Yuchung Cheng" wrote: > > The original patch that changes TCP's congestion control via eBPF only > re-initializes the new congestion control, if the BPF op is set to an > (invalid) value beyond BPF_SOCK_OP

Re: [PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Lawrence Brakmo
On 1/23/18, 9:30 AM, "Yuchung Cheng" wrote: The original patch that changes TCP's congestion control via eBPF only re-initializes the new congestion control, if the BPF op is set to an (invalid) value beyond BPF_SOCK_OPS_NEEDS_ECN. Consequently TCP will What do you mean by “(invalid)

[PATCH net] bpf: always re-init the congestion control after switching to it

2018-01-23 Thread Yuchung Cheng
The original patch that changes TCP's congestion control via eBPF only re-initializes the new congestion control, if the BPF op is set to an (invalid) value beyond BPF_SOCK_OPS_NEEDS_ECN. Consequently TCP will run the new congestion control from random states. This patch fixes the issue by always r