Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-29 Thread Matteo Croce
On Thu, Sep 28, 2017 at 1:22 PM, Erik Kline wrote: > Upon further reflection, doesn't the whole premise of this change > means that it's no longer possible to selectively disable these > features if they are set on "all"? Or are we saying that this mode is > only support with

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-28 Thread Erik Kline
On 28 September 2017 at 13:47, Erik Kline wrote: >> Erik, please review. > > I apologize for the delay. I see that you've already applied this, and > it's mostly LGTM except I have one thing I'm not seeing clearly. > > The documentation accept_dad now claims: > > DAD

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-27 Thread Erik Kline
> Erik, please review. I apologize for the delay. I see that you've already applied this, and it's mostly LGTM except I have one thing I'm not seeing clearly. The documentation accept_dad now claims: DAD operation and mode on a given interface will be selected according to the maximum

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-19 Thread David Miller
From: Matteo Croce Date: Tue, 12 Sep 2017 17:46:37 +0200 > Currently, writing into > net.ipv6.conf.all.{accept_dad,use_optimistic,optimistic_dad} has no effect. > Fix handling of these flags by: > > - using the maximum of global and per-interface values for the > accept_dad

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-15 Thread David Miller
From: Matteo Croce Date: Tue, 12 Sep 2017 17:46:37 +0200 > Currently, writing into > net.ipv6.conf.all.{accept_dad,use_optimistic,optimistic_dad} has no effect. > Fix handling of these flags by: > > - using the maximum of global and per-interface values for the > accept_dad

[PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-12 Thread Matteo Croce
Currently, writing into net.ipv6.conf.all.{accept_dad,use_optimistic,optimistic_dad} has no effect. Fix handling of these flags by: - using the maximum of global and per-interface values for the accept_dad flag. That is, if at least one of the two values is non-zero, enable DAD on the