Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Sun, Oct 25, 2015, at 14:32, Tom Herbert wrote: > > Anyway, currently it is easy to generate broken checksums on the wire > > and would like to solve that for net, we certainly can improve that in > > net-next. > > > Hannes, > > The IPv4 fragment code is very similar to IPv6 in that both will

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Mon, Oct 26, 2015, at 20:39, Tom Herbert wrote: > On Mon, Oct 26, 2015 at 11:44 AM, Hannes Frederic Sowa > wrote: > > > > > > On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: > >> > We already concluded that drivers do have this problem and not the stack > >> >

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Mon, Oct 26, 2015 at 11:44 AM, Hannes Frederic Sowa wrote: > > > On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: >> > We already concluded that drivers do have this problem and not the stack >> > above ip6_fragment. The places I am aware of I fixed in this patch.

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: > > We already concluded that drivers do have this problem and not the stack > > above ip6_fragment. The places I am aware of I fixed in this patch. Also > > IPv4 to me seems unaffected, albeit one can certainly clean up the logic > > in

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

> We already concluded that drivers do have this problem and not the stack > above ip6_fragment. The places I am aware of I fixed in this patch. Also > IPv4 to me seems unaffected, albeit one can certainly clean up the logic > in net-next. > I don't understand why checksum for IP fragments is a

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

> Anyway, currently it is easy to generate broken checksums on the wire > and would like to solve that for net, we certainly can improve that in > net-next. > Hannes, The IPv4 fragment code is very similar to IPv6 in that both will perform skb_checksum_help only in the slow_path, so it seems like

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa wrote: > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets > in ip6_append_data. Some drivers don't correctly handle extension headers, > especially not ipv6 fragmentation which could result

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Sat, Oct 24, 2015 at 12:28 PM, Hannes Frederic Sowa wrote: > Hi Tom, > > On Sat, Oct 24, 2015, at 18:21, Tom Herbert wrote: >> On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa >> wrote: >> > CHECKSUM_PARTIAL should only be used on

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

Hi Tom, On Sat, Oct 24, 2015, at 18:46, Tom Herbert wrote: > On Sat, Oct 24, 2015 at 12:28 PM, Hannes Frederic Sowa > wrote: > > Hi Tom, > > > > On Sat, Oct 24, 2015, at 18:21, Tom Herbert wrote: > >> On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa > >>

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

Hi Tom, On Sat, Oct 24, 2015, at 18:21, Tom Herbert wrote: > On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa > wrote: > > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets > > in ip6_append_data. Some drivers don't correctly handle

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

Hi, On Sat, Oct 24, 2015, at 00:48, Eric Dumazet wrote: > On Fri, 2015-10-23 at 15:13 +0200, Hannes Frederic Sowa wrote: > > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets > > in ip6_append_data. Some drivers don't correctly handle extension headers, > > especially not

[PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets in ip6_append_data. Some drivers don't correctly handle extension headers, especially not ipv6 fragmentation which could result in broken checksums. 1) This patch improves the test for fragmentation and extension headers in

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Fri, 2015-10-23 at 15:13 +0200, Hannes Frederic Sowa wrote: > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets > in ip6_append_data. Some drivers don't correctly handle extension headers, > especially not ipv6 fragmentation which could result in broken checksums. > > 1)