Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread Hangbin Liu
Hi David, On Mon, Sep 10, 2018 at 08:39:34PM -0600, David Ahern wrote: > On 9/10/18 7:04 PM, Hangbin Liu wrote: > > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > index 18e00ce..62621b4 100644 > > --- a/net/ipv6/route.c > > +++ b/net/ipv6/route.c > > @@ -998,6 +998,21 @@ static void

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread David Ahern
On 9/10/18 7:04 PM, Hangbin Liu wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 18e00ce..62621b4 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -998,6 +998,21 @@ static void ip6_rt_copy_init(struct rt6_info *rt, struct > fib6_info *ort) > rt->rt6i_prefsrc =

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread Hangbin Liu
On Mon, Sep 10, 2018 at 01:07:11PM -0600, David Ahern wrote: > On 9/10/18 11:55 AM, Xin Long wrote: > > On Tue, Sep 11, 2018 at 12:13 AM David Ahern > > wrote: > >> > >> On 9/9/18 12:29 AM, Xin Long wrote: > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > index 18e00ce..e554922

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread David Ahern
On 9/10/18 11:55 AM, Xin Long wrote: > On Tue, Sep 11, 2018 at 12:13 AM David Ahern wrote: >> >> On 9/9/18 12:29 AM, Xin Long wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 18e00ce..e554922 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread Xin Long
On Tue, Sep 11, 2018 at 12:13 AM David Ahern wrote: > > On 9/9/18 12:29 AM, Xin Long wrote: > >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > >>> index 18e00ce..e554922 100644 > >>> --- a/net/ipv6/route.c > >>> +++ b/net/ipv6/route.c > >>> @@ -4670,20 +4670,33 @@ static int

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread David Ahern
On 9/9/18 12:29 AM, Xin Long wrote: >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>> index 18e00ce..e554922 100644 >>> --- a/net/ipv6/route.c >>> +++ b/net/ipv6/route.c >>> @@ -4670,20 +4670,33 @@ static int rt6_fill_node(struct net *net, struct >>> sk_buff *skb, >>>

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-09 Thread Xin Long
On Sun, Sep 9, 2018 at 9:45 AM David Ahern wrote: > > On 9/8/18 3:24 AM, Xin Long wrote: > > In inet6_rtm_getroute, since Commit 93531c674315 ("net/ipv6: separate > > handling of FIB entries from dst based routes"), it has used rt->from > > to dump route info instead of rt. > > > > However for

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-08 Thread David Ahern
On 9/8/18 3:24 AM, Xin Long wrote: > In inet6_rtm_getroute, since Commit 93531c674315 ("net/ipv6: separate > handling of FIB entries from dst based routes"), it has used rt->from > to dump route info instead of rt. > > However for some route like cache, its information is not the same as > that

[PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-08 Thread Xin Long
In inet6_rtm_getroute, since Commit 93531c674315 ("net/ipv6: separate handling of FIB entries from dst based routes"), it has used rt->from to dump route info instead of rt. However for some route like cache, its information is not the same as that of the 'from' one. It caused 'ip -6 route get'