Re: [PATCH net] macvlan: filter out xfrm feature flags

2018-03-08 Thread Shannon Nelson
On 3/8/2018 9:33 AM, David Miller wrote: From: Shannon Nelson Date: Tue, 6 Mar 2018 14:57:08 -0800 This isn't broken for vlans because they use a separate features connection (vlan_features) for inheriting features. This is fine, but I don't think trying to add something like this to every d

Re: [PATCH net] macvlan: filter out xfrm feature flags

2018-03-08 Thread David Miller
From: Shannon Nelson Date: Tue, 6 Mar 2018 14:57:08 -0800 > This isn't broken for vlans because they use a separate features > connection (vlan_features) for inheriting features. This is > fine, but I don't think trying to add something like this to > every driver for every new upperdev is a go

[PATCH net] macvlan: filter out xfrm feature flags

2018-03-06 Thread Shannon Nelson
Adding a macvlan device on top of a lowerdev that supports the xfrm offloads fails. # ip link add link ens1f0 mv0 type macvlan RTNETLINK answers: Operation not permitted Tracing down the failure shows that the macvlan device inherits the NETIF_F_HW_ESP and NETIF_F_HW_ESP_TX_CSUM feature fl