Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-27 Thread Saeed Mahameed
On Fri, Jul 27, 2018 at 8:59 AM, Kamal Heib wrote: > On Thu, Jul 26, 2018 at 11:51:49AM -0700, Saeed Mahameed wrote: >> On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib wrote: >> > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's >> > only used there. >> > >> > Fixes:

Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-27 Thread Kamal Heib
On Thu, Jul 26, 2018 at 11:51:49AM -0700, Saeed Mahameed wrote: > On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib wrote: > > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's > > only used there. > > > > Fixes: 4e59e2888139 ("net/mlx5e: Introduce net device priv flags > >

Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-26 Thread Saeed Mahameed
On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib wrote: > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's > only used there. > > Fixes: 4e59e2888139 ("net/mlx5e: Introduce net device priv flags > infrastructure") > Signed-off-by: Kamal Heib > --- >

Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-17 Thread Kamal Heib
On Tue, Jul 17, 2018 at 08:00:58AM -0700, Saeed Mahameed wrote: > On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib wrote: > > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's > > only used there. > > > > Fixes: 4e59e2888139 ("net/mlx5e: Introduce net device priv flags > >

Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-17 Thread Saeed Mahameed
On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib wrote: > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's > only used there. > > Fixes: 4e59e2888139 ("net/mlx5e: Introduce net device priv flags > infrastructure") > Signed-off-by: Kamal Heib > --- LGTM, but why to net ? this

[PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-15 Thread Kamal Heib
Move the definition of mlx5e_priv_flags into en_ethtool.c because it's only used there. Fixes: 4e59e2888139 ("net/mlx5e: Introduce net device priv flags infrastructure") Signed-off-by: Kamal Heib --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 7 ---