Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-09 Thread David Ahern
On 10/9/17 9:25 AM, Nicolas Dichtel wrote: > Le 09/10/2017 à 16:02, David Ahern a écrit : >> On 10/9/17 2:23 AM, Nicolas Dichtel wrote: >>> Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : On 10/06/2017 08:18 PM, David Ahern wrote: > On 10/5/17 4:19 AM, Nicolas Dichtel wrote:

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-09 Thread Nicolas Dichtel
Le 09/10/2017 à 16:02, David Ahern a écrit : > On 10/9/17 2:23 AM, Nicolas Dichtel wrote: >> Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : >>> >>> >>> On 10/06/2017 08:18 PM, David Ahern wrote: On 10/5/17 4:19 AM, Nicolas Dichtel wrote: > IFLA_IFALIAS is defined as NLA_STRING. It means

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-09 Thread David Ahern
On 10/9/17 2:23 AM, Nicolas Dichtel wrote: > Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : >> >> >> On 10/06/2017 08:18 PM, David Ahern wrote: >>> On 10/5/17 4:19 AM, Nicolas Dichtel wrote: IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of the attribute is 1

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-09 Thread Nicolas Dichtel
Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : > > > On 10/06/2017 08:18 PM, David Ahern wrote: >> On 10/5/17 4:19 AM, Nicolas Dichtel wrote: >>> IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of >>> the attribute is 1 ("\0"). However, to remove an alias, the attribute

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-06 Thread Oliver Hartkopp
On 10/06/2017 08:18 PM, David Ahern wrote: On 10/5/17 4:19 AM, Nicolas Dichtel wrote: IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of the attribute is 1 ("\0"). However, to remove an alias, the attribute length must be 0 (see dev_set_alias()). why not add a check

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-06 Thread David Ahern
On 10/5/17 4:19 AM, Nicolas Dichtel wrote: > IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of > the attribute is 1 ("\0"). However, to remove an alias, the attribute > length must be 0 (see dev_set_alias()). why not add a check in dev_set_alias that if len is 1 and the 1

[PATCH net] net: enable interface alias removal via rtnl

2017-10-05 Thread Nicolas Dichtel
IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of the attribute is 1 ("\0"). However, to remove an alias, the attribute length must be 0 (see dev_set_alias()). Let's define the type to NLA_BINARY, so that the alias can be removed. Example: $ ip l s dummy0 alias foo $ ip