Re: [PATCH net] net: sungem: fix rx checksum support

2018-08-27 Thread Eric Dumazet
On Sun, Aug 26, 2018 at 6:14 AM wrote: > > > BTW, removing the FCS also means GRO is going to work, finally on this NIC > > ;) > > > > GRO does not like packets with padding. > > As a follow-up, I am seeing hw csum failures on Sun V440 that has > onboard Sun Cassini with sungem driver. First

Re: [PATCH net] net: sungem: fix rx checksum support

2018-08-26 Thread mroos
> BTW, removing the FCS also means GRO is going to work, finally on this NIC ;) > > GRO does not like packets with padding. As a follow-up, I am seeing hw csum failures on Sun V440 that has onboard Sun Cassini with sungem driver. First tested version was 4.18 (it happened there once) and now

Re: [PATCH net] net: sungem: fix rx checksum support

2018-06-21 Thread Eric Dumazet
On 06/19/2018 10:30 PM, David Miller wrote: > Tested-by: Andreas Schwab > > Applied and queued up for -stable, thanks Eric. > BTW, removing the FCS also means GRO is going to work, finally on this NIC ;) GRO does not like packets with padding.

Re: [PATCH net] net: sungem: fix rx checksum support

2018-06-20 Thread Eric Dumazet
On 06/20/2018 04:22 AM, Mathieu Malaterre wrote: > Thanks for the stable tag. > > IMHO the commit message should have also reference commit 7ce5a27f2ef8 > ("Revert "net: Handle CHECKSUM_COMPLETE more adequately in > pskb_trim_rcsum().""). Which means that commit 88078d98d1bb ("net: >

Re: [PATCH net] net: sungem: fix rx checksum support

2018-06-20 Thread Mathieu Malaterre
On Wed, Jun 20, 2018 at 7:31 AM David Miller wrote: > > From: Eric Dumazet > Date: Tue, 19 Jun 2018 19:18:50 -0700 > > > After commit 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE > > are friends"), sungem owners reported the infamous "eth0: hw csum failure" > > message. > > > >

Re: [PATCH net] net: sungem: fix rx checksum support

2018-06-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Jun 2018 19:18:50 -0700 > After commit 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE > are friends"), sungem owners reported the infamous "eth0: hw csum failure" > message. > > CHECKSUM_COMPLETE has in fact never worked for this driver, but this >

[PATCH net] net: sungem: fix rx checksum support

2018-06-19 Thread Eric Dumazet
After commit 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"), sungem owners reported the infamous "eth0: hw csum failure" message. CHECKSUM_COMPLETE has in fact never worked for this driver, but this was masked by the fact that upper stacks had to strip the FCS, and