Re: [PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-21 Thread David Miller
From: Xin Long Date: Fri, 21 Sep 2018 15:55:34 +0800 > It's under the protection of the sock lock, I think any other places > that want to access the address also need to acquire this sock lock > first. Hash table lookups don't even have a socket context yet, so can't hold the sock lock, but

Re: [PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-21 Thread Xin Long
On Fri, Sep 21, 2018 at 2:31 AM David Miller wrote: > > From: Xin Long > Date: Thu, 20 Sep 2018 17:27:28 +0800 > > > When processing pmtu update from an icmp packet, it calls .update_pmtu > > with sk instead of skb in sctp_transport_update_pmtu. > > > > However for sctp, the daddr in the

Re: [PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-20 Thread David Miller
From: Xin Long Date: Thu, 20 Sep 2018 17:27:28 +0800 > When processing pmtu update from an icmp packet, it calls .update_pmtu > with sk instead of skb in sctp_transport_update_pmtu. > > However for sctp, the daddr in the transport might be different from > inet_sock->inet_daddr or

Re: [PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-20 Thread Marcelo Ricardo Leitner
On Thu, Sep 20, 2018 at 05:27:28PM +0800, Xin Long wrote: > When processing pmtu update from an icmp packet, it calls .update_pmtu > with sk instead of skb in sctp_transport_update_pmtu. > > However for sctp, the daddr in the transport might be different from > inet_sock->inet_daddr or

[PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-20 Thread Xin Long
When processing pmtu update from an icmp packet, it calls .update_pmtu with sk instead of skb in sctp_transport_update_pmtu. However for sctp, the daddr in the transport might be different from inet_sock->inet_daddr or sk->sk_v6_daddr, which is used to update or create the route cache. The