Re: [PATCH net] sfc: pass valid pointers from efx_enqueue_unwind

2017-12-08 Thread David Miller
From: Bert Kenward Date: Thu, 7 Dec 2017 17:18:58 + > The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers > cannot be NULL. Add a paranoid warning to check this condition and fix > the one case where they were NULL. > > efx_enqueue_unwind() is

Re: [PATCH net] sfc: pass valid pointers from efx_enqueue_unwind

2017-12-08 Thread Jarod Wilson
On 2017-12-07 12:18 PM, Bert Kenward wrote: The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers cannot be NULL. Add a paranoid warning to check this condition and fix the one case where they were NULL. efx_enqueue_unwind() is called very rarely, during error handling. Without

[PATCH net] sfc: pass valid pointers from efx_enqueue_unwind

2017-12-07 Thread Bert Kenward
The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers cannot be NULL. Add a paranoid warning to check this condition and fix the one case where they were NULL. efx_enqueue_unwind() is called very rarely, during error handling. Without this fix it would fail with a NULL pointer