Re: [PATCH net] tcp: fastopen: fix on syn-data transmit failure

2017-09-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 Sep 2017 10:05:57 -0700 > From: Eric Dumazet > > Our recent change exposed a bug in TCP Fastopen Client that syzkaller > found right away [1] > > When we prepare skb with SYN+DATA, we attempt to transmit it, > and

Re: [PATCH net] tcp: fastopen: fix on syn-data transmit failure

2017-09-19 Thread Yuchung Cheng
On Tue, Sep 19, 2017 at 10:05 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Our recent change exposed a bug in TCP Fastopen Client that syzkaller > found right away [1] > > When we prepare skb with SYN+DATA, we attempt to transmit it, > and we

[PATCH net] tcp: fastopen: fix on syn-data transmit failure

2017-09-19 Thread Eric Dumazet
From: Eric Dumazet Our recent change exposed a bug in TCP Fastopen Client that syzkaller found right away [1] When we prepare skb with SYN+DATA, we attempt to transmit it, and we update socket state as if the transmit was a success. In socket RTX queue we have two skbs,