Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-20 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 23:18:44 -0800 On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote: Also, as the function names are longer than the macro name you are creating lines that are 80 columns wide that used not to be in that state. For my eyes that

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_type(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches

[PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_type(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote: On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_type(__be32 addr) Adds some type safety and arguably some readability No change

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 11:18:44PM -0800, Joe Perches wrote: On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote: On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_type(__be32 addr)

[PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-14 Thread Joe Perches
Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and maybe some readability No change in compiled image size Signed-off-by: Joe Perches [EMAIL PROTECTED] - To unsubscribe from this list: send the line