Re: [PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing and padding

2016-01-05 Thread David Miller
From: Jarod Wilson Date: Tue, 5 Jan 2016 18:12:34 -0500 > - if ((raw_mtu + 8) < ALX_TXQ1_JUMBO_TSO_TH) > - val = (raw_mtu + 8 + 7) >> 3; > + if ((raw_mtu) < ALX_TXQ1_JUMBO_TSO_TH) > + val = (raw_mtu + 7) >> 3; The parenthesis around 'raw_mtu' is superfluous, plea

[PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing and padding

2016-01-05 Thread Jarod Wilson
This is based on the work done by Przemek Rudy in bug 70761 at bugzilla.kernel.org, but with some work done to disentagle and clarify things a bit. Similar to Przemek's work and other drivers, we're adding a padding of 16 here, but we're also disentangling mtu size calculations from max buffer siz