Re: [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave

2016-05-10 Thread Sergei Shtylyov 

Hello.

On 5/10/2016 4:28 AM, Taku Izumi wrote:


commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().


   scripts/checkpatch.pl now enforces a certain commit citing style, yours 
doesn't match it.



This spin_lock_irqsave() is obviously unnecessary.

This patch eliminates unnecessary spin_lock_irqsave() in
fjes_change_mtu()

Signed-off-by: Taku Izumi 

[...]

   The "Fixes:" tag would also be in order...

MBR, Sergei

Re: [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave

2016-05-09 Thread David Miller 
From: Taku Izumi 
Date: Tue, 10 May 2016 10:28:49 +0900

> commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().
> This spin_lock_irqsave() is obviously unnecessary.
> 
> This patch eliminates unnecessary spin_lock_irqsave() in
> fjes_change_mtu()
> 
> Signed-off-by: Taku Izumi 

Applied, thanks.

[PATCH net-next] fjes: Fix unnecessary spinlock_irqsave

2016-05-09 Thread Taku Izumi 
commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().
This spin_lock_irqsave() is obviously unnecessary.

This patch eliminates unnecessary spin_lock_irqsave() in
fjes_change_mtu()

Signed-off-by: Taku Izumi 
---
 drivers/net/fjes/fjes_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index f4e6926..86c331b 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -819,7 +819,6 @@ static int fjes_change_mtu(struct net_device *netdev, int 
new_mtu)
netdev->mtu = new_mtu;
 
if (running) {
-   spin_lock_irqsave(>rx_status_lock, flags);
for (epidx = 0; epidx < hw->max_epid; epidx++) {
if (epidx == hw->my_epid)
continue;
-- 
1.9.1