RE: [PATCH net-next] net/tls: Corrected enabling of zero-copy mode

2018-07-26 Thread Vakul Garg
t...@fb.com > Subject: Re: [PATCH net-next] net/tls: Corrected enabling of zero-copy mode > > From: Vakul Garg > Date: Mon, 23 Jul 2018 21:00:06 +0530 > > > @@ -787,7 +787,7 @@ int tls_sw_recvmsg(struct sock *sk, > > target = sock_rcvlowat(sk, flags & MSG_WA

Re: [PATCH net-next] net/tls: Corrected enabling of zero-copy mode

2018-07-25 Thread David Miller
From: Vakul Garg Date: Mon, 23 Jul 2018 21:00:06 +0530 > @@ -787,7 +787,7 @@ int tls_sw_recvmsg(struct sock *sk, > target = sock_rcvlowat(sk, flags & MSG_WAITALL, len); > timeo = sock_rcvtimeo(sk, flags & MSG_DONTWAIT); > do { > - bool zc = false; > +

[PATCH net-next] net/tls: Corrected enabling of zero-copy mode

2018-07-23 Thread Vakul Garg
Zero-copy mode was left enabled even when zerocopy_from_iter() failed. In this case, control falls back to regular non zero-copy mode. This caused skipping call of datagram copy function skb_copy_datagram_msg() and required an extra iteration of record decryption loop for decrypted record to be