Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice

2018-07-24 Thread Vakul Garg
From: Al Viro Sent: Wednesday, 25 July, 7:19 AM Subject: Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice To: Vakul Garg Cc: netdev@vger.kernel.org, bor...@mellanox.com, avia...@mellanox.com, davejwat...@fb.com, da...@davemloft.net On Tue, Jul 24, 2018 at 04:41:18PM +0530

Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice

2018-07-24 Thread Al Viro
On Tue, Jul 24, 2018 at 04:41:18PM +0530, Vakul Garg wrote: > In function tls_sw_sendmsg(), msg_data_left() needs to be called only > once. The second invocation of msg_data_left() for assigning variable > try_to_copy can be removed and merged with the first one. You do realize that

[PATCH net-next] net/tls: Do not call msg_data_left() twice

2018-07-23 Thread Vakul Garg
In function tls_sw_sendmsg(), msg_data_left() needs to be called only once. The second invocation of msg_data_left() for assigning variable try_to_copy can be removed and merged with the first one. Signed-off-by: Vakul Garg --- net/tls/tls_sw.c | 3 +-- 1 file changed, 1 insertion(+), 2