On 07/12/18 11:14 AM, Vakul Garg wrote:
> Hi Boris
>
> Thanks for explaining.
> Few questions/observations.
>
> 1. Isn't ' ctx->decrypted = true' a redundant statement in
> tls_do_decryption()?
> The same has been repeated in tls_recvmsg() after calling decrypt_skb()?
>
> 2. Similarly, ctx->sav
ssage-
> From: Boris Pismenny [mailto:bor...@mellanox.com]
> Sent: Thursday, July 12, 2018 4:11 PM
> To: Vakul Garg ; da...@davemloft.net;
> davejwat...@fb.com; netdev@vger.kernel.org
> Cc: avia...@mellanox.com
> Subject: Re: [PATCH net-next] net/tls: Removed redundant variable from
>
Hi Vakul,
On 7/12/2018 7:03 AM, Vakul Garg wrote:
The variable 'decrypted' in 'struct tls_sw_context_rx' is redundant and
is being set/unset without purpose. Simplified the code by removing it.
AFAIU, this variable has an important use here. It keeps the state
whether the current record has
The variable 'decrypted' in 'struct tls_sw_context_rx' is redundant and
is being set/unset without purpose. Simplified the code by removing it.
Signed-off-by: Vakul Garg
---
include/net/tls.h | 1 -
net/tls/tls_sw.c | 87 ---
2 files changed,