Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

Hello David, sorry for the delay. At Sun, 11 Oct 2015 12:01:30 -0600, David Ahern wrote: > > On 10/11/15 8:24 AM, Hajime Tazaki wrote: > > > > I've faced this issue since the following patch was applied. > > > > commit 741a11d9e4103a8e1c590ef1280143fe654e4e33 > > Author: David Ahern

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/20/15 6:31 AM, Hajime Tazaki wrote: yes, this sendmsg uses non-zero flowi6_oif. the conditions are - sendmsg () with INET6/RAW socket (with IPPROTO_MH) - ip6_pktinfo.ipi6_addr (fl6.saddr) and ipi6_oif (fl6.flowi6_oif) are non-NULL. => ipi6_addr (fl6.saddr) is not the IP address of

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

At Tue, 20 Oct 2015 11:48:48 -0600, David Ahern wrote: > > the conditions are > > > > - sendmsg () with INET6/RAW socket (with IPPROTO_MH) > > - ip6_pktinfo.ipi6_addr (fl6.saddr) and ipi6_oif > >(fl6.flowi6_oif) are non-NULL. > > => ipi6_addr (fl6.saddr) is not the IP address of oif, but > >

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On Mon, Oct 12, 2015 at 12:49:29PM -0600, David Ahern wrote: > On 10/9/15 11:27 AM, David Ahern wrote: > >On 10/9/15 1:17 AM, Steffen Klassert wrote: > diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c > index 30caa289c5db..5cedfda4b241 100644 > ---

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

Hi David. On Mon, Oct 12, 2015 at 12:49:29PM -0600, David Ahern wrote: > On 10/9/15 11:27 AM, David Ahern wrote: > > > >The attached patch applied to Linus' tree works for me. Currently the > >above change is not in his tree, so I added it to this patch. Once you > >confirm that it works for you

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/9/15 11:27 AM, David Ahern wrote: On 10/9/15 1:17 AM, Steffen Klassert wrote: diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 30caa289c5db..5cedfda4b241 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c @@ -37,6 +37,7 @@ static struct dst_entry

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

At Fri, 9 Oct 2015 11:27:36 -0600, David Ahern wrote: > > [1 ] > On 10/9/15 1:17 AM, Steffen Klassert wrote: > >>> diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c > >>> index 30caa289c5db..5cedfda4b241 100644 > >>> --- a/net/ipv6/xfrm6_policy.c > >>> +++ b/net/ipv6/xfrm6_policy.c

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/11/15 7:22 AM, Hajime Tazaki wrote: At Fri, 9 Oct 2015 11:27:36 -0600, David Ahern wrote: [1 ] On 10/9/15 1:17 AM, Steffen Klassert wrote: diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 30caa289c5db..5cedfda4b241 100644 --- a/net/ipv6/xfrm6_policy.c +++

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

At Sun, 11 Oct 2015 07:31:32 -0600, David Ahern wrote: > >> The attached patch applied to Linus' tree works for me. Currently the > >> above change is not in his tree, so I added it to this patch. Once you > >> confirm that it works for you I'll create the delta-patch for net and > >> send out.

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/11/15 8:24 AM, Hajime Tazaki wrote: I've faced this issue since the following patch was applied. commit 741a11d9e4103a8e1c590ef1280143fe654e4e33 Author: David Ahern Date: Mon Sep 28 10:12:13 2015 -0700 net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

Hello David, At Mon, 5 Oct 2015 08:32:51 -0600, David Ahern wrote: > > diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c > index 30caa289c5db..5cedfda4b241 100644 > --- a/net/ipv6/xfrm6_policy.c > +++ b/net/ipv6/xfrm6_policy.c > @@ -37,6 +37,7 @@ static struct dst_entry

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On Fri, Oct 09, 2015 at 03:54:22PM +0900, Hajime Tazaki wrote: > > Hello David, > > At Mon, 5 Oct 2015 08:32:51 -0600, > David Ahern wrote: > > > > > diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c > > index 30caa289c5db..5cedfda4b241 100644 > > --- a/net/ipv6/xfrm6_policy.c >

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/9/15 1:17 AM, Steffen Klassert wrote: On Fri, Oct 09, 2015 at 03:54:22PM +0900, Hajime Tazaki wrote: Hello David, At Mon, 5 Oct 2015 08:32:51 -0600, David Ahern wrote: diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 30caa289c5db..5cedfda4b241 100644 ---

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/9/15 1:17 AM, Steffen Klassert wrote: diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 30caa289c5db..5cedfda4b241 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c @@ -37,6 +37,7 @@ static struct dst_entry *xfrm6_dst_lookup(struct net *net, int tos,

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

From: David Ahern Date: Mon, 5 Oct 2015 08:32:51 -0600 > It occurred to me yesterday that 741a11d9e4103 ("net: ipv6: Add > RT6_LOOKUP_F_IFACE flag if oif is set") means that xfrm6_dst_lookup > needs the FLOWI_FLAG_SKIP_NH_OIF flag set. This latest commit causes > the

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/7/15 5:25 AM, David Miller wrote: From: David Ahern Date: Mon, 5 Oct 2015 08:32:51 -0600 It occurred to me yesterday that 741a11d9e4103 ("net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set") means that xfrm6_dst_lookup needs the FLOWI_FLAG_SKIP_NH_OIF flag

[PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

It occurred to me yesterday that 741a11d9e4103 ("net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set") means that xfrm6_dst_lookup needs the FLOWI_FLAG_SKIP_NH_OIF flag set. This latest commit causes the oif to be considered in lookups which is known to break vti. This explains why 58189ca7b274