Re: [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare

[David Miller]

From: YueHaibing 
Date: Wed, 16 May 2018 19:18:22 +0800

> clk_disable_unprepare() already checks that the clock pointer is valid.
> No need to test it before calling it.
> 
> Signed-off-by: YueHaibing 

Applied.

Re: [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare

[Tobias Klauser]

On 2018-05-16 at 13:18:22 +0200, YueHaibing  wrote:
> clk_disable_unprepare() already checks that the clock pointer is valid.
> No need to test it before calling it.
> 
> Signed-off-by: YueHaibing 

Reviewed-by: Tobias Klauser 

[PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare

[YueHaibing]

clk_disable_unprepare() already checks that the clock pointer is valid.
No need to test it before calling it.

Signed-off-by: YueHaibing 
---
 drivers/net/ethernet/ethoc.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index 8bb0db9..00a5727 100644
--- a/drivers/net/ethernet/ethoc.c
+++ b/drivers/net/ethernet/ethoc.c
@@ -1246,8 +1246,7 @@ static int ethoc_probe(struct platform_device *pdev)
mdiobus_unregister(priv->mdio);
mdiobus_free(priv->mdio);
 free2:
-   if (priv->clk)
-   clk_disable_unprepare(priv->clk);
+   clk_disable_unprepare(priv->clk);
 free:
free_netdev(netdev);
 out:
@@ -1271,8 +1270,7 @@ static int ethoc_remove(struct platform_device *pdev)
mdiobus_unregister(priv->mdio);
mdiobus_free(priv->mdio);
}
-   if (priv->clk)
-   clk_disable_unprepare(priv->clk);
+   clk_disable_unprepare(priv->clk);
unregister_netdev(netdev);
free_netdev(netdev);
}
-- 
2.7.0