Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-02 Thread Tariq Toukan
On 02/04/2018 6:19 PM, Eric Dumazet wrote: On 04/02/2018 08:00 AM, Eran Ben Elisha wrote: Seems good, but why isn't this handled directly in GRO native layer ? ip6_tunnel and ip6_gre do not share initialization flow functions (unlike ipv4). Changing the ipv6 init infrastructure should not b

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-02 Thread Eric Dumazet
On 04/02/2018 08:00 AM, Eran Ben Elisha wrote: Seems good, but why isn't this handled directly in GRO native layer ? >>> ip6_tunnel and ip6_gre do not share initialization flow functions (unlike >>> ipv4). >>> Changing the ipv6 init infrastructure should not be part of this >>> patch. we pr

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-02 Thread Eran Ben Elisha
>>> Seems good, but why isn't this handled directly in GRO native layer ? >> ip6_tunnel and ip6_gre do not share initialization flow functions (unlike >> ipv4). >> Changing the ipv6 init infrastructure should not be part of this >> patch. we prefer to keep this one minimal, simple and safe. > > >

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-02 Thread Eric Dumazet
On 04/02/2018 05:40 AM, Eran Ben Elisha wrote: > On Sun, Apr 1, 2018 at 7:35 PM, Eric Dumazet wrote: >> >> >> On 04/01/2018 06:17 AM, Tariq Toukan wrote: >>> From: Eran Ben Elisha >>> >>> Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells >>> infrastructure. >>> >>> Perform

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-02 Thread Eran Ben Elisha
On Sun, Apr 1, 2018 at 7:35 PM, Eric Dumazet wrote: > > > On 04/01/2018 06:17 AM, Tariq Toukan wrote: >> From: Eran Ben Elisha >> >> Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells >> infrastructure. >> >> Performance testing: 55% higher badwidth. >> Measuring bandwidth of

Re: [PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-01 Thread Eric Dumazet
On 04/01/2018 06:17 AM, Tariq Toukan wrote: > From: Eran Ben Elisha > > Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells > infrastructure. > > Performance testing: 55% higher badwidth. > Measuring bandwidth of 1 thread IPv4 TCP traffic over IPv6 GRE tunnel > while GRO on

[PATCH net-next] net: ipv6/gre: Add GRO support

2018-04-01 Thread Tariq Toukan
From: Eran Ben Elisha Add GRO capability for IPv6 GRE tunnel and ip6erspan tap, via gro_cells infrastructure. Performance testing: 55% higher badwidth. Measuring bandwidth of 1 thread IPv4 TCP traffic over IPv6 GRE tunnel while GRO on the physical interface is disabled. CPU: Intel Xeon E312xx (S