Re: [PATCH net-next] qed: Fix an off by one bug

[David Miller]

From: Dan Carpenter 
Date: Wed, 14 Jun 2017 12:10:10 +0300

> The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so
> the > here should be a >= or we write beyond the end of the array.
> 
> Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid")
> Signed-off-by: Dan Carpenter 

Applied.

RE: [PATCH net-next] qed: Fix an off by one bug

[Mintz, Yuval]

> The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so
> the > here should be a >= or we write beyond the end of the array.
> 
> Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid")
> Signed-off-by: Dan Carpenter 

While it's a theoretical fix [as check is defensive; the queue-id was supposed
to be validated before reaching this part], it's still the right. Thanks Dan.

Acked-by: Yuval Mintz 

[PATCH net-next] qed: Fix an off by one bug

[Dan Carpenter]

The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so
the > here should be a >= or we write beyond the end of the array.

Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid")
Signed-off-by: Dan Carpenter 

diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c 
b/drivers/net/ethernet/qlogic/qed/qed_l2.c
index cb8b05dbfc6e..e57699bfbdfa 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
@@ -161,7 +161,7 @@ static bool qed_eth_queue_qid_usage_add(struct qed_hwfn 
*p_hwfn,
 
mutex_lock(&p_l2_info->lock);
 
-   if (queue_id > p_l2_info->queues) {
+   if (queue_id >= p_l2_info->queues) {
DP_NOTICE(p_hwfn,
  "Requested to increase usage for qzone %04x out of 
%08x\n",
  queue_id, p_l2_info->queues);