Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

2018-10-11 Thread David Howells
Dan Carpenter wrote: > I told him to do that because it wasn't a bugfix... Probably just Fixes > is the right thing to use though. But the correct fix *is* a bug fix. David

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

2018-10-11 Thread Dan Carpenter
On Tue, Oct 09, 2018 at 11:13:16AM +0100, David Howells wrote: > YueHaibing wrote: > > > net/rxrpc/output.c: In function 'rxrpc_reject_packets': > > net/rxrpc/output.c:527:11: warning: > > variable 'ioc' set but not used [-Wunused-but-set-variable] > > > > It never used since introduction in >

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

2018-10-09 Thread YueHaibing
On 2018/10/9 18:13, David Howells wrote: > YueHaibing wrote: > >> net/rxrpc/output.c: In function 'rxrpc_reject_packets': >> net/rxrpc/output.c:527:11: warning: >> variable 'ioc' set but not used [-Wunused-but-set-variable] >> >> It never used since introduction in > > I wonder why my compiler

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

2018-10-09 Thread David Howells
YueHaibing wrote: > net/rxrpc/output.c: In function 'rxrpc_reject_packets': > net/rxrpc/output.c:527:11: warning: > variable 'ioc' set but not used [-Wunused-but-set-variable] > > It never used since introduction in I wonder why my compiler doesn't show this warning. Anyway, NAK: just

[PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

2018-10-08 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: net/rxrpc/output.c: In function 'rxrpc_reject_packets': net/rxrpc/output.c:527:11: warning: variable 'ioc' set but not used [-Wunused-but-set-variable] It never used since introduction in commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed