Re: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread David Miller
From: Vakul Garg Date: Wed, 26 Sep 2018 04:19:25 + > BTW, I noticed following build failure. > It gets resolved after reverting d6ab93364734. > > CC [M] drivers/net/phy/marvell.o > drivers/net/phy/marvell.c: In function 'm88e1121_config_aneg': > drivers/net/phy/marvell.c:468:25: error:

RE: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread Vakul Garg
> -Original Message- > From: David Miller > Sent: Wednesday, September 26, 2018 9:10 AM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCH net-next] tls: Fix socket

Re: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread David Miller
From: Vakul Garg Date: Wed, 26 Sep 2018 01:54:25 + > I don't find this patch and one other ("tls: Fixed a memory leak > during socket close") in linux-net-next. Could you please kindly > check? Regards. After applying I didn't push out and instead I started a test build, closed my laptop,

RE: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread Vakul Garg
> -Original Message- > From: David Miller > Sent: Tuesday, September 25, 2018 11:14 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCH net-next] tls: Fix socket

Re: [PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread David Miller
From: Vakul Garg Date: Tue, 25 Sep 2018 16:26:17 +0530 > Current async encryption implementation sometimes showed up socket > memory accounting error during socket close. This results in kernel > warning calltrace. The root cause of the problem is that socket var > sk_forward_alloc gets

[PATCH net-next] tls: Fix socket mem accounting error under async encryption

2018-09-25 Thread Vakul Garg
Current async encryption implementation sometimes showed up socket memory accounting error during socket close. This results in kernel warning calltrace. The root cause of the problem is that socket var sk_forward_alloc gets corrupted due to access in sk_mem_charge() and sk_mem_uncharge() being