Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-18 Thread Pablo Neira Ayuso
On Wed, Jun 17, 2015 at 07:08:15PM +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > From: Eric Dumazet > > > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > > so that bytes and packets sit in same cache line. > > > > xt_counter being exported to user space, we can

Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-18 Thread Pablo Neira Ayuso
On Thu, Jun 18, 2015 at 03:43:26AM -0700, David Miller wrote: > From: Eric Dumazet > Date: Mon, 15 Jun 2015 18:10:13 -0700 > > > From: Eric Dumazet > > > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > > so that bytes and packets sit in same cache line. > > > > xt_counte

Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-18 Thread David Miller
From: Eric Dumazet Date: Mon, 15 Jun 2015 18:10:13 -0700 > From: Eric Dumazet > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > so that bytes and packets sit in same cache line. > > xt_counter being exported to user space, we cannot add __align(16) on > the structure its

Re: [PATCH net-next] x_table: align per cpu xt_counter

2015-06-17 Thread Florian Westphal
Eric Dumazet wrote: > From: Eric Dumazet > > Let's force a 16 bytes alignment on xt_counter percpu allocations, > so that bytes and packets sit in same cache line. > > xt_counter being exported to user space, we cannot add __align(16) on > the structure itself. Sorry, I was away. Looks great.

[PATCH net-next] x_table: align per cpu xt_counter

2015-06-15 Thread Eric Dumazet
From: Eric Dumazet Let's force a 16 bytes alignment on xt_counter percpu allocations, so that bytes and packets sit in same cache line. xt_counter being exported to user space, we cannot add __align(16) on the structure itself. Signed-off-by: Eric Dumazet Cc: Florian Westphal --- include/lin