Re: [PATCH net-next 00/11] FUJITSU Extended Socket driver version 1.1

2016-04-12 Thread David Miller 
From: "Izumi, Taku" 
Date: Tue, 12 Apr 2016 08:35:09 +

>  But I'd like to keep some debugfs facility for status information
>  and some specific stats other thatn net_stats.

We have a facility for arbitrary driver stats, remove this debugfs crap
please.

I'm not going to say this again.

RE: [PATCH net-next 00/11] FUJITSU Extended Socket driver version 1.1

2016-04-12 Thread Izumi, Taku 
Dear David and Jiri,

  Thank you for reviewing!

> This submission is of an extremely low quality.
> 
> All of your ioctl additions are completely inappropriate, as are your
> debugfs facilities.  You must remove all of them completely.

 OK, I'll remove ioctl part. But I'd like to keep some debugfs facility
 for status information and some specific stats other thatn net_stats.

 Are you okay with this ?

 Sincerely,
 Taku Izumi

Re: [PATCH net-next 00/11] FUJITSU Extended Socket driver version 1.1

2016-04-11 Thread David Miller 

This submission is of an extremely low quality.

All of your ioctl additions are completely inappropriate, as are your
debugfs facilities.  You must remove all of them completely.

[PATCH net-next 00/11] FUJITSU Extended Socket driver version 1.1

2016-04-11 Thread Taku Izumi 
This patchsets update FUJITSU Extended Socket network driver into version 1.1.
This mainly includes debugging feature and some minor bugfix. 


Taku Izumi (11):
  fjes: Add trace-gathering facility
  fjes: Add setting/getting register value feature via ioctl
  fjes: Add debugs facility for fjes module
  fjes: Add debugfs entry for statistics
  fjes: show EP stats at statistics file in debugfs
  fjes: optimize timeout value
  fjes: fix incorrect statistics information in fjes_xmit_frame()
  fjes: fix bitwise check bug in fjes_raise_intr_rxdata_task
  fjes: Enhance changing MTU related work
  fjes: Introduce spinlock for rx_status
  fjes: Update fjes driver version : 1.1

 drivers/net/fjes/Makefile   |   2 +-
 drivers/net/fjes/fjes.h |  16 ++
 drivers/net/fjes/fjes_debugfs.c | 212 +
 drivers/net/fjes/fjes_hw.c  | 179 +-
 drivers/net/fjes/fjes_hw.h  |  43 -
 drivers/net/fjes/fjes_ioctl.h   |  93 ++
 drivers/net/fjes/fjes_main.c| 400 +---
 7 files changed, 909 insertions(+), 36 deletions(-)
 create mode 100644 drivers/net/fjes/fjes_debugfs.c
 create mode 100644 drivers/net/fjes/fjes_ioctl.h

-- 
2.4.3