Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-08 Thread Jamal Hadi Salim
On 2018-10-08 2:11 a.m., Al Viro wrote: On Sun, Oct 07, 2018 at 10:55:52PM -0700, David Miller wrote: From: Al Viro Date: Mon, 8 Oct 2018 06:45:15 +0100 Er... Both are due to missing in the very beginning of the series (well, on top of "net: sched: cls_u32: fix hnode refcounting") commit

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-08 Thread Al Viro
On Sun, Oct 07, 2018 at 10:55:52PM -0700, David Miller wrote: > From: Al Viro > Date: Mon, 8 Oct 2018 06:45:15 +0100 > > > Er... Both are due to missing in the very beginning of the series (well, on > > top of "net: sched: cls_u32: fix hnode refcounting") commit > > All dependencies like this

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread David Miller
From: Al Viro Date: Mon, 8 Oct 2018 06:45:15 +0100 > Er... Both are due to missing in the very beginning of the series (well, on > top of "net: sched: cls_u32: fix hnode refcounting") commit All dependencies like this must be explicitly stated. And in such situations you actually should wait

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread Al Viro
On Sun, Oct 07, 2018 at 09:25:01PM -0700, David Miller wrote: > From: Jamal Hadi Salim > Date: Sun, 7 Oct 2018 12:38:00 -0400 > > > Various improvements from Al. > > Please submit changes that actually are compile tested: > > CC [M] net/sched/cls_u32.o > net/sched/cls_u32.c: In function

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 7 Oct 2018 12:38:00 -0400 > Various improvements from Al. Please submit changes that actually are compile tested: CC [M] net/sched/cls_u32.o net/sched/cls_u32.c: In function ‘u32_delete’: net/sched/cls_u32.c:674:6: error: ‘root_ht’ undeclared (first use in

[PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Various improvements from Al. Al Viro (11): net: sched: cls_u32: disallow linking to root hnode net: sched: cls_u32: make sure that divisor is a power of 2 net: sched: cls_u32: get rid of unused argument of u32_destroy_key() net: sched: cls_u32: get rid of