Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 5:04 PM, Harald Welte wrote: > Hi Tom, > > On Wed, Sep 20, 2017 at 01:40:54PM -0700, Tom Herbert wrote: >> On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote: >> > There is a socket associated with the tunnel to do the

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Harald Welte
Hi Tom, On Wed, Sep 20, 2017 at 01:40:54PM -0700, Tom Herbert wrote: > On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote: > > There is a socket associated with the tunnel to do the encapsulation > > and it has an address family, right? > > If fd's are set from userspace

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote: > From: Tom Herbert > Date: Wed, 20 Sep 2017 11:03:52 -0700 > >> On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote: >>> From: Tom Herbert >>> Date: Mon,

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread David Miller
From: Tom Herbert Date: Wed, 20 Sep 2017 11:03:52 -0700 > On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote: >> From: Tom Herbert >> Date: Mon, 18 Sep 2017 17:38:58 -0700 >> >>> Allow peers to be specified by IPv6 addresses. >>>

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Tom Herbert
On Mon, Sep 18, 2017 at 9:19 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 18 Sep 2017 17:38:58 -0700 > >> Allow peers to be specified by IPv6 addresses. >> >> Signed-off-by: Tom Herbert > > Hmmm, can you just check the

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-19 Thread Harald Welte
Hi Tom, On Mon, Sep 18, 2017 at 05:38:58PM -0700, Tom Herbert wrote: > Allow peers to be specified by IPv6 addresses. > + u16 peer_af; > + union { > + struct in_addr peer_addr_ip4; > + struct in6_addr peer_addr_ip6; > + }; this will not

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-18 Thread David Miller
From: Tom Herbert Date: Mon, 18 Sep 2017 17:38:58 -0700 > Allow peers to be specified by IPv6 addresses. > > Signed-off-by: Tom Herbert Hmmm, can you just check the socket family or something like that?

[PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-18 Thread Tom Herbert
Allow peers to be specified by IPv6 addresses. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 198 +-- include/uapi/linux/gtp.h | 1 + include/uapi/linux/if_link.h | 3 + 3 files changed, 158 insertions(+), 44