Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jamal Hadi Salim
On 17-01-15 04:11 AM, Jiri Pirko wrote: Subject should contain "V2" Sat, Jan 14, 2017 at 10:52:44PM CET, j...@mojatatu.com wrote: From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like

Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jiri Pirko
Subject should contain "V2" Sat, Jan 14, 2017 at 10:52:44PM CET, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Introduce optional 128-bit action cookie. >Like all other cookie schemes in the networking world (eg in protocols >like http or existing kernel fib protocol

[PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-14 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel

Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-14 Thread John Fastabend
On 17-01-14 07:49 AM, Jiri Pirko wrote: > Sat, Jan 14, 2017 at 04:39:24PM CET, j...@mojatatu.com wrote: >> On 17-01-14 10:22 AM, Jiri Pirko wrote: >> .. create an accept action with cookie 0xA:0xa0a0a0a0a0a0a0 sudo $TC actions add action ok index 1 cookie 0xA 0xa0a0a0a0a0a0a0 >>> >>> 2x

Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-14 Thread Jiri Pirko
Sat, Jan 14, 2017 at 04:39:24PM CET, j...@mojatatu.com wrote: >On 17-01-14 10:22 AM, Jiri Pirko wrote: > >> > .. create an accept action with cookie 0xA:0xa0a0a0a0a0a0a0 >> > sudo $TC actions add action ok index 1 cookie 0xA 0xa0a0a0a0a0a0a0 >> >> 2x 64bit values? Why can't this have variable

Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-14 Thread Jamal Hadi Salim
On 17-01-14 10:22 AM, Jiri Pirko wrote: .. create an accept action with cookie 0xA:0xa0a0a0a0a0a0a0 sudo $TC actions add action ok index 1 cookie 0xA 0xa0a0a0a0a0a0a0 2x 64bit values? Why can't this have variable length, according to what user needs: You can intepret it however you wish.

Re: [PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-14 Thread Jiri Pirko
Sat, Jan 14, 2017 at 03:59:18PM CET, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Introduce optional 128-bit action cookie. >Like all other cookie schemes in the networking world (eg in protocols >like http or existing kernel fib protocol field, etc) the idea is to save

[PATCH net-next 1/1] net sched actions: Add support for user cookies

2017-01-14 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel