Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan

2016-08-25 Thread David Miller
From: Hariprasad Shenai Date: Wed, 24 Aug 2016 12:20:33 +0530 > + dev_info(pi->adapter->pdev_dev, > + "Setting Vlan %u to VF [%d]\n", vlan, vf); > + dev_info(pi->adapter->pdev_dev, > + "The VF [%d] interface needs to brought down and up,

RE: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan

2016-08-24 Thread Yuval Mintz
> > Are you preventing VGT configuration once VST is configured? > > If not, what to prevent VM user from configuring vlan interfaces on > > top of the VF, even if VST is configured? > Again this misses documentation, what if VLAN interface is already configured > in > VM before VST is

Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan

2016-08-24 Thread Hariprasad Shenai
On Wednesday, August 08/24/16, 2016 at 08:31:58 +, Yuval Mintz wrote: > > > > @@ -1202,6 +1202,10 @@ int t4vf_eth_xmit(struct sk_buff *skb, struct > > > > net_device *dev) > > > > BUG_ON(qidx >= pi->nqsets); > > > > txq = >sge.ethtxq[pi->first_qset + qidx]; > > > > > > > > +

RE: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan

2016-08-24 Thread Yuval Mintz
> > > @@ -1202,6 +1202,10 @@ int t4vf_eth_xmit(struct sk_buff *skb, struct > > > net_device *dev) > > > BUG_ON(qidx >= pi->nqsets); > > > txq = >sge.ethtxq[pi->first_qset + qidx]; > > > > > > + if (pi->vlan_id && !skb_vlan_tag_present(skb)) > > > + __vlan_hwaccel_put_tag(skb,

Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan

2016-08-24 Thread Hariprasad Shenai
On Wednesday, August 08/24/16, 2016 at 07:08:14 +, Yuval Mintz wrote: > > @@ -1202,6 +1202,10 @@ int t4vf_eth_xmit(struct sk_buff *skb, struct > > net_device *dev) > > BUG_ON(qidx >= pi->nqsets); > > txq = >sge.ethtxq[pi->first_qset + qidx]; > > > > + if (pi->vlan_id &&

RE: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan

2016-08-24 Thread Yuval Mintz
> @@ -1202,6 +1202,10 @@ int t4vf_eth_xmit(struct sk_buff *skb, struct > net_device *dev) > BUG_ON(qidx >= pi->nqsets); > txq = >sge.ethtxq[pi->first_qset + qidx]; > > + if (pi->vlan_id && !skb_vlan_tag_present(skb)) > + __vlan_hwaccel_put_tag(skb,

[PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf_vlan

2016-08-24 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 21 +++ drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 25 +