Re: [PATCH net-next 1/3] uapi: add MACsec bits

2016-03-10 Thread Sabrina Dubroca
Hi Johannes, 2016-03-09, 12:34:23 +0100, Johannes Berg wrote: > On Wed, 2016-03-09 at 11:51 +0100, Sabrina Dubroca wrote: > > > > + MACSEC_ATTR_ICV_LEN, > > > > + MACSEC_TXSA_LIST, > > > > + MACSEC_RXSC_LIST, > > > > + MACSEC_TXSC_STATS, > > > > + MACSEC_SECY_STATS,

Re: [PATCH net-next 1/3] uapi: add MACsec bits

2016-03-09 Thread Johannes Berg
On Wed, 2016-03-09 at 11:51 +0100, Sabrina Dubroca wrote: > > > +#define DEFAULT_CIPHER_NAME "GCM-AES-128" > > > +#define DEFAULT_CIPHER_ID   0x008002000101ULL > > > +#define DEFAULT_CIPHER_ALT  0x0080C2000101ULL > > > > > +enum macsec_attrs { > > [...] > > > + MACSEC_ATTR_CIPHER_SUITE,

Re: [PATCH net-next 1/3] uapi: add MACsec bits

2016-03-09 Thread Sabrina Dubroca
2016-03-08, 20:52:48 +0100, Johannes Berg wrote: > On Mon, 2016-03-07 at 18:12 +0100, Sabrina Dubroca wrote: > > > +++ b/include/uapi/linux/if_macsec.h > > Some bits of documentation in this file, regarding all the various > operations and attributes, might be nice. At least the netlink types?

Re: [PATCH net-next 1/3] uapi: add MACsec bits

2016-03-08 Thread Johannes Berg
On Mon, 2016-03-07 at 18:12 +0100, Sabrina Dubroca wrote: > +++ b/include/uapi/linux/if_macsec.h Some bits of documentation in this file, regarding all the various operations and attributes, might be nice. At least the netlink types? E.g., given this: > +#define DEFAULT_CIPHER_NAME

[PATCH net-next 1/3] uapi: add MACsec bits

2016-03-07 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Hannes Frederic Sowa --- v1: - rebase RFCv2: - add include, detected by the kbuild robot - split off the attributes for RXSC and SA from enum macsec_attrs --- include/uapi/linux/Kbuild | 1 +

[RFCv2 PATCH net-next 1/3] uapi: add MACsec bits

2016-02-02 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Hannes Frederic Sowa --- RFCv2: - add include, detected by the kbuild robot - split off the attributes for RXSC and SA from enum macsec_attrs include/uapi/linux/Kbuild | 1 +

[RFC PATCH net-next 1/3] uapi: add MACsec bits

2015-12-28 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Hannes Frederic Sowa --- include/uapi/linux/Kbuild | 1 + include/uapi/linux/if_ether.h | 1 + include/uapi/linux/if_link.h | 21 ++ include/uapi/linux/if_macsec.h | 160