Re: [PATCH net-next 1/4] net: qualcomm: rmnet: Fix casting issues

2018-03-13 Thread Subash Abhinov Kasiviswanathan
Ummm, if you change pkt_len to be a proper __be16, then you don't need these casts when passing it to ntohs(). Hi David I have fixed this now in v2. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH net-next 1/4] net: qualcomm: rmnet: Fix casting issues

2018-03-13 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Mon, 12 Mar 2018 20:26:06 -0600 > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > index 6ce31e2..65b074e 100644 > ---

[PATCH net-next 1/4] net: qualcomm: rmnet: Fix casting issues

2018-03-12 Thread Subash Abhinov Kasiviswanathan
Fix warnings which were reported when running with sparse (make C=1 CF=-D__CHECK_ENDIAN__) drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:81:15: warning: cast to restricted __be16 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:271:37: warning: incorrect type in assignment (different