RE: [PATCH net-next 1/4] xen-netback: add control ring boilerplate

2016-05-10 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 10 May 2016 14:29 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; Wei Liu > Subject: Re: [PATCH net-next 1/4] xen-netback: add control ring boilerplate > > On

Re: [PATCH net-next 1/4] xen-netback: add control ring boilerplate

2016-05-10 Thread Wei Liu
On Thu, May 05, 2016 at 12:19:27PM +0100, Paul Durrant wrote: [...] > > +static int connect_ctrl_ring(struct backend_info *be) > +{ Please use goto style error handling in this function. Other than this the code looks good. Wei.

[PATCH net-next 1/4] xen-netback: add control ring boilerplate

2016-05-05 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new shared ring (in addition to the rx and tx rings) for passing control messages from a VM frontend driver to a backend driver. This patch adds the necessary code to xen-netback to map this new shared ring, should it be created by a