Re: [PATCH net-next 1/5] ipv4: add __ip_queue_xmit() that supports tos param

2018-06-25 Thread Xin Long
On Mon, Jun 25, 2018 at 7:13 PM, Neil Horman wrote: > On Mon, Jun 25, 2018 at 04:26:54PM +0900, David Miller wrote: >> From: Xin Long >> Date: Mon, 25 Jun 2018 10:14:33 +0800 >> >> > +EXPORT_SYMBOL(__ip_queue_xmit); >> > + >> > +int ip_queue_xmit(struct sock *sk, struct sk_buff *skb, struct

Re: [PATCH net-next 1/5] ipv4: add __ip_queue_xmit() that supports tos param

2018-06-25 Thread Neil Horman
On Mon, Jun 25, 2018 at 04:26:54PM +0900, David Miller wrote: > From: Xin Long > Date: Mon, 25 Jun 2018 10:14:33 +0800 > > > +EXPORT_SYMBOL(__ip_queue_xmit); > > + > > +int ip_queue_xmit(struct sock *sk, struct sk_buff *skb, struct flowi *fl) > > +{ > > + return __ip_queue_xmit(sk, skb, fl,

Re: [PATCH net-next 1/5] ipv4: add __ip_queue_xmit() that supports tos param

2018-06-25 Thread David Miller
From: Xin Long Date: Mon, 25 Jun 2018 10:14:33 +0800 > +EXPORT_SYMBOL(__ip_queue_xmit); > + > +int ip_queue_xmit(struct sock *sk, struct sk_buff *skb, struct flowi *fl) > +{ > + return __ip_queue_xmit(sk, skb, fl, inet_sk(sk)->tos); > +} > EXPORT_SYMBOL(ip_queue_xmit); Maybe better to only

[PATCH net-next 1/5] ipv4: add __ip_queue_xmit() that supports tos param

2018-06-24 Thread Xin Long
This patch introduces __ip_queue_xmit(), through which the callers can pass tos param into it without having to set inet->tos. For ipv6, ip6_xmit() already allows passing tclass parameter. It's needed when some transport protocol doesn't use inet->tos, like sctp's per transport dscp, which will