Re: [PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors

2017-12-07 Thread David Miller
From: David Ahern Date: Thu, 7 Dec 2017 10:52:01 -0700 > What value are the messages providing above and beyond the standard libc > strerror(errno)? In the case of ENOMEM, there is nothing in the user can > do to fix that particular command, so why bloat the code with

Re: [PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors

2017-12-07 Thread David Ahern
On 12/7/17 5:04 AM, Jamal Hadi Salim wrote: > On 17-12-07 12:28 AM, David Ahern wrote: > >>>   -    err = nla_parse_nested(tb, TCA_STAB_MAX, opt, stab_policy, NULL); >>> -    if (err < 0) >>> +    err = nla_parse_nested(tb, TCA_STAB_MAX, opt, stab_policy, extack); >>> +    if (err < 0) { >>> +

Re: [PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors

2017-12-06 Thread David Ahern
On 12/6/17 9:08 AM, Alexander Aring wrote: > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > index a48ca41b7ecf..7b52a16d2fea 100644 > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -449,7 +449,8 @@ static const struct nla_policy stab_policy[TCA_STAB_MAX + > 1] = { >

Re: [PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors

2017-12-06 Thread Jamal Hadi Salim
On 17-12-06 11:08 AM, Alexander Aring wrote: This patch adds extack support for generic qdisc handling. The extack will be set deeper to each called function which is not part of netdev core api. A future patchset will add per-qdisc specific changes. Cc: David Ahern

[PATCH net-next 1/6] net: sched: sch_api: handle generic qdisc errors

2017-12-06 Thread Alexander Aring
This patch adds extack support for generic qdisc handling. The extack will be set deeper to each called function which is not part of netdev core api. A future patchset will add per-qdisc specific changes. Cc: David Ahern Signed-off-by: Alexander Aring ---