Re: [PATCH net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause

2018-09-03 Thread Florian Fainelli
On 09/03/18 12:58, Andrew Lunn wrote: >> Don't you want to go one step further and incorporate the logic that xgenet, >> tg3, gianfar and others have? That is: look at the currently advertised >> parameters, determine what changed, and re-start auto-negotiation as a >> result of it being

Re: [PATCH net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause

2018-09-03 Thread Andrew Lunn
> Don't you want to go one step further and incorporate the logic that xgenet, > tg3, gianfar and others have? That is: look at the currently advertised > parameters, determine what changed, and re-start auto-negotiation as a > result of it being enabled and something changed? Hi Florian Given

Re: [PATCH net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause

2018-09-03 Thread Florian Fainelli
On 9/2/2018 10:06 AM, Andrew Lunn wrote: ethtool can be used to enable/disable pause. Add a helper to configure the PHY when asym pause is supported. Don't you want to go one step further and incorporate the logic that xgenet, tg3, gianfar and others have? That is: look at the currently

[PATCH net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause

2018-09-02 Thread Andrew Lunn
ethtool can be used to enable/disable pause. Add a helper to configure the PHY when asym pause is supported. Signed-off-by: Andrew Lunn --- .../ethernet/apm/xgene/xgene_enet_ethtool.c | 26 ++--- drivers/net/ethernet/aurora/nb8800.c | 9 +--- drivers/net/ethernet/broadcom/tg3.c