Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Eric Dumazet
On Fri, 2015-06-12 at 18:50 -0700, Alexei Starovoitov wrote: sure, that's better. If you're going to submit it officialy, please add my Tested-by. My server is happy now :) Sure , will do. I tried adding __must_check to __skb_header_pointer() but apparently had to use W=1 to get a warning

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2015 at 06:37:34PM -0700, Eric Dumazet wrote: On Fri, 2015-06-12 at 18:27 -0700, Alexei Starovoitov wrote: On Fri, Jun 12, 2015 at 09:01:06AM -0700, Tom Herbert wrote: If dst, hop-by-hop or routing extension headers are present determine length of the options and skip over

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Eric Dumazet
On Fri, 2015-06-12 at 18:27 -0700, Alexei Starovoitov wrote: On Fri, Jun 12, 2015 at 09:01:06AM -0700, Tom Herbert wrote: If dst, hop-by-hop or routing extension headers are present determine length of the options and skip over them in flow dissection. Signed-off-by: Tom Herbert

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2015 at 07:11:16PM -0700, Eric Dumazet wrote: On Fri, 2015-06-12 at 18:50 -0700, Alexei Starovoitov wrote: sure, that's better. If you're going to submit it officialy, please add my Tested-by. My server is happy now :) Sure , will do. I tried adding __must_check

Re: [PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2015 at 09:01:06AM -0700, Tom Herbert wrote: If dst, hop-by-hop or routing extension headers are present determine length of the options and skip over them in flow dissection. Signed-off-by: Tom Herbert t...@herbertland.com --- net/core/flow_dissector.c | 17

[PATCH net-next 2/2] flow_dissector: add support for dst, hop-by-hop and routing ext hdrs

2015-06-12 Thread Tom Herbert
If dst, hop-by-hop or routing extension headers are present determine length of the options and skip over them in flow dissection. Signed-off-by: Tom Herbert t...@herbertland.com --- net/core/flow_dissector.c | 17 + 1 file changed, 17 insertions(+) diff --git