Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Saeed Mahameed
On Mon, Oct 31, 2016 at 1:11 AM, Saeed Mahameed wrote: > On Mon, Oct 31, 2016 at 12:44 AM, Alexei Starovoitov > wrote: >> On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: >>> >>> Note that the XDP TX rings are no longer shown

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Saeed Mahameed
On Mon, Oct 31, 2016 at 12:44 AM, Alexei Starovoitov wrote: > On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: >> >> Note that the XDP TX rings are no longer shown in ethtool -S. > > ouch. Can you make it to show them as some large TX numbers instead? >

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Alexei Starovoitov
On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: > > Note that the XDP TX rings are no longer shown in ethtool -S. ouch. Can you make it to show them as some large TX numbers instead? It would really sux to lose stats on them.

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Tariq Toukan
On 28/10/2016 4:07 AM, Alexei Starovoitov wrote: On Thu, Oct 27, 2016 at 05:52:04PM +0300, Tariq Toukan wrote: Separately manage the two types of TX rings: regular ones, and XDP. Upon an XDP set, do not borrow regular TX rings and convert them into XDP ones, but allocate new ones, unless we

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-29 Thread Brenden Blanco
On Thu, Oct 27, 2016 at 06:07:02PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 27, 2016 at 05:52:04PM +0300, Tariq Toukan wrote: > > Separately manage the two types of TX rings: regular ones, and XDP. > > Upon an XDP set, do not borrow regular TX rings and convert them > > into XDP ones, but

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-27 Thread Alexei Starovoitov
On Thu, Oct 27, 2016 at 05:52:04PM +0300, Tariq Toukan wrote: > Separately manage the two types of TX rings: regular ones, and XDP. > Upon an XDP set, do not borrow regular TX rings and convert them > into XDP ones, but allocate new ones, unless we hit the max number > of rings. > Which means that

[PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-27 Thread Tariq Toukan
Separately manage the two types of TX rings: regular ones, and XDP. Upon an XDP set, do not borrow regular TX rings and convert them into XDP ones, but allocate new ones, unless we hit the max number of rings. Which means that in systems with smaller #cores we will not consume the current TX rings