Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Andrew Lunn
> Do i need to change Ethtool application and submit along with > downshift driver patch (i.e. ethtool.c, phy.c, cpsw.c and mscc.c changes) ? Yes, please submit two patchset. One patchset for ethtool and its man page and a second patchset for all the kernel changes. Thanks Andrew

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Raju Lakkaraju
Hi Andrew, On Tue, Oct 18, 2016 at 12:58:20PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > > In fact, this looks a lot like netdev features (e.g: checksum > > > offload), and there seems to be some commonality here between at > > > least Marvell and Microsemi (for the faster link down

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Andrew Lunn
> > In fact, this looks a lot like netdev features (e.g: checksum > > offload), and there seems to be some commonality here between at > > least Marvell and Microsemi (for the faster link down reporting), > > so maybe we should start adding PHY features similar to netdev > > features? > Sure. >

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Raju Lakkaraju
Hi Florian, Thank you for review comments. On Mon, Oct 17, 2016 at 05:51:11AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On October 17, 2016 1:13:14 AM PDT, Raju Lakkaraju > wrote: > >Hi Andrew, > > > >Thank you for code review and comments. > > > >On

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-17 Thread Florian Fainelli
On October 17, 2016 1:13:14 AM PDT, Raju Lakkaraju wrote: >Hi Andrew, > >Thank you for code review and comments. > >On Fri, Oct 14, 2016 at 02:02:28PM +0200, Andrew Lunn wrote: >> EXTERNAL EMAIL >> >> >> > On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and comments. On Fri, Oct 14, 2016 at 02:02:28PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > VSC8531 Fast Link Failure 2

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-14 Thread Andrew Lunn
> On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > VSC8531 Fast Link Failure 2 feature enables the PHY to indicate the > onset of a potential link failure in < 100 usec for 100BASE-TX > operation. FLF2 is supported through

[PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-14 Thread Raju Lakkaraju
From: Raju Lakkaraju VSC8531 Fast Link Failure 2 feature enables the PHY to indicate the onset of a potential link failure in < 100 usec for 100BASE-TX operation. FLF2 is supported through the MDINT (active low) pin. Signed-off-by: Raju Lakkaraju