Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Florian/Andrew, Thank you for review comments. On Thu, Oct 06, 2016 at 04:09:56AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 10/05/2016 12:18 AM, Andrew Lunn wrote: > + phydev->mdix = ETH_TP_MDI_AUTO; > >>> > >>> Humm, interesting. The only other driver supporting mdix

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 10:24:51PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > + reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); > > + if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { > > + reg_val

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-17 Thread Raju Lakkaraju
Hi Florian/Andrew, Thank you for review comments. On Thu, Oct 06, 2016 at 03:57:32AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 09/28/2016 01:24 PM, Andrew Lunn wrote: > >> static int vsc85xx_wol_set(struct phy_device *phydev, > >> struct ethtool_wolinfo *

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-06 Thread Florian Fainelli
On 10/05/2016 12:18 AM, Andrew Lunn wrote: + phydev->mdix = ETH_TP_MDI_AUTO; >>> >>> Humm, interesting. The only other driver supporting mdix is the >>> Marvell one. It does not do this, it leaves it to its default value of >>> ETH_TP_MDI_INVALID. It does however interpret ETH_TP_MDI_INV

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-06 Thread Florian Fainelli
On 09/28/2016 01:24 PM, Andrew Lunn wrote: >> static int vsc85xx_wol_set(struct phy_device *phydev, >> struct ethtool_wolinfo *wol) >> { >> @@ -227,6 +281,7 @@ static int vsc85xx_default_config(struct phy_device >> *phydev) >> int rc; >> u16 reg_val; >> >> +

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-05 Thread Andrew Lunn
> > > + phydev->mdix = ETH_TP_MDI_AUTO; > > > > Humm, interesting. The only other driver supporting mdix is the > > Marvell one. It does not do this, it leaves it to its default value of > > ETH_TP_MDI_INVALID. It does however interpret ETH_TP_MDI_INVALID as > > meaning as ETH_TP_MDI_AUTO. > >

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-10-04 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 10:24:51PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > + reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); > > + if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { > > + reg_val

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-09-28 Thread Andrew Lunn
> + reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); > + if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { > + reg_val |= (DISABLE_PAIR_SWAP_CORR_MASK | > + DISABLE_POLARITY_CORR_MASK | > + DISABLE_HP_AUTO_MDIX_MASK); > +

[PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
From: Raju Lakkaraju To connect two ports of the same configuration (MDI to MDI or MDI-X to MDI-X) with a 10/100/1000 Mbit/s connection, an Ethernet crossover cable is needed to cross over the transmit and receive signals in the cable, so that they are matched at the connector level. When connect