Iff TSU registers exist on a given [G]Ether controller, they always include
the CAM entry table registers (TSU_ADR{H|L}<n>), thus the check for invalid
TSU_ADRH0 offset in __sh_eth_get_regs() is useless...

Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>

---
 drivers/net/ethernet/renesas/sh_eth.c |   23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net-next/drivers/net/ethernet/renesas/sh_eth.c
@@ -2153,22 +2153,17 @@ static size_t __sh_eth_get_regs(struct n
                add_tsu_reg(TSU_POST2);
                add_tsu_reg(TSU_POST3);
                add_tsu_reg(TSU_POST4);
-               if (mdp->reg_offset[TSU_ADRH0] != SH_ETH_OFFSET_INVALID) {
-                       /* This is the start of a table, not just a single
-                        * register.
-                        */
-                       if (buf) {
-                               unsigned int i;
+               /* This is the start of a table, not just a single register. */
+               if (buf) {
+                       unsigned int i;
 
-                               mark_reg_valid(TSU_ADRH0);
-                               for (i = 0; i < SH_ETH_TSU_CAM_ENTRIES * 2; i++)
-                                       *buf++ = ioread32(
-                                               mdp->tsu_addr +
-                                               mdp->reg_offset[TSU_ADRH0] +
-                                               i * 4);
-                       }
-                       len += SH_ETH_TSU_CAM_ENTRIES * 2;
+                       mark_reg_valid(TSU_ADRH0);
+                       for (i = 0; i < SH_ETH_TSU_CAM_ENTRIES * 2; i++)
+                               *buf++ = ioread32(mdp->tsu_addr +
+                                                 mdp->reg_offset[TSU_ADRH0] +
+                                                 i * 4);
                }
+               len += SH_ETH_TSU_CAM_ENTRIES * 2;
        }
 
 #undef mark_reg_valid

Reply via email to