Re: [PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments

[Andrew Lunn]

On Wed, Jun 08, 2016 at 08:44:50PM -0400, Vivien Didelot wrote:
> The chip->ds and ds->slave_mii_bus assignments are common to both legacy
> and new MDIO probing and are already done in the later setup code.
> 
> Remove the duplicated assignments from the MDIO probing code.
> 
> Signed-off-by: Vivien Didelot 

Reviewed-by: Andrew Lunn 

Andrew

[PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments

[Vivien Didelot]

The chip->ds and ds->slave_mii_bus assignments are common to both legacy
and new MDIO probing and are already done in the later setup code.

Remove the duplicated assignments from the MDIO probing code.

Signed-off-by: Vivien Didelot 
---
 drivers/net/dsa/mv88e6xxx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 6a2528f..cb8b1b7 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -3706,7 +3706,6 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev)
ds->priv = ps;
ds->dev = dev;
ps->dev = dev;
-   ps->ds = ds;
ps->bus = mdiodev->bus;
ps->sw_addr = mdiodev->addr;
mutex_init(>smi_mutex);
@@ -3746,8 +3745,6 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev)
if (err)
return err;
 
-   ds->slave_mii_bus = ps->mdio_bus;
-
dev_set_drvdata(dev, ds);
 
err = dsa_register_switch(ds, mdiodev->dev.of_node);
-- 
2.8.3